Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation: Add validation for Provisioner #261

Closed
eytan-avisror opened this issue Mar 15, 2021 · 0 comments · Fixed by #267
Closed

Validation: Add validation for Provisioner #261

eytan-avisror opened this issue Mar 15, 2021 · 0 comments · Fixed by #267
Labels
bug Something isn't working controller

Comments

@eytan-avisror
Copy link
Collaborator

It seems we get a NPE when referenced provisioner is nil.
This causes the controller to crash.

e.g.

apiVersion: instancemgr.keikoproj.io/v1alpha1
kind: InstanceGroup
metadata:
  name: hello-world
  namespace: instance-manager
spec:
  provisioner: eks-managed
  eks:
    < ... >

We should add proper validation and error out instead of crashing the controller in this case.

CC: @uthark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working controller
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant