Additional volume options

[eytan-avisror]

Fixes #155

Adds additional volume options to NodeVolumes

[codecov]

Codecov Report

Merging #161 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   89.54%   89.54%           
=======================================
  Files          13       13           
  Lines        1607     1607           
=======================================
  Hits         1439     1439           
  Misses        111      111           
  Partials       57       57           

Impacted Files	Coverage Δ
controllers/provisioners/eks/helpers.go	90.09% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa48faa...e20c922. Read the comment docs.

[shaoxt]

This feature is to gather IOPS, DeleteonTermination and Encrypted info from AWS right ?

[eytan-avisror]

This feature is to gather IOPS, DeleteonTermination and Encrypted info from AWS right ?

It's to allow these fields to be configurable in the custom resource

[shaoxt]

OK, what if the old configuration doesn't have UserDataStage/data or UserDataStage/stage ?
Will it causes failure or the validation could take care of the case ?

This feature is to gather IOPS, DeleteonTermination and Encrypted info from AWS right ?

It's to allow these fields to be configurable in the custom resource

[eytan-avisror]

OK, what if the old configuration doesn't have UserDataStage/data or UserDataStage/stage ?
Will it causes failure or the validation could take care of the case ?

This feature is to gather IOPS, DeleteonTermination and Encrypted info from AWS right ?

It's to allow these fields to be configurable in the custom resource

The UserDataStage type changes are backwards compatible, we only added a "name" field and this PR also makes it 'omitempty' to make sure if an old CR did not have this field it won't break.
The name field we added is for convenience anyway and is not mandatory

we did make the other two fields (stage, data) required, because without them it would fail anyway

[vgunapati]

LGTM

[shaoxt]

LGTM