Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow IOPS config option for io1 volumeType #155

Closed
vgunapati opened this issue Jul 31, 2020 · 2 comments · Fixed by #161
Closed

Allow IOPS config option for io1 volumeType #155

vgunapati opened this issue Jul 31, 2020 · 2 comments · Fixed by #161
Labels
enhancement New feature or request feature request
Milestone

Comments

@vgunapati
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST?:
FEATURE
What happened:
Allow IOPS config option for io1 volumeType

type NodeVolume struct {
Name string `json:"name,omitempty"`
Type string `json:"type,omitempty"`
Size int64 `json:"size,omitempty"`

More Details about io1
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ebs-volume-types.html

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Kubernetes version:
kubectl version -o yaml

Other debugging information (if applicable):

  • InstanceGroup status:
kubectl describe instancegroup <ig-name>
  • controller logs:
kubectl logs <instance-manager pod>
@eytan-avisror
Copy link
Collaborator

@vgunapati this should work if you set volume type to io1 in the instance group spec.

@eytan-avisror
Copy link
Collaborator

We should add all options from:
https://github.com/aws/aws-sdk-go/blob/v1.33.16/service/autoscaling/api.go#L9676-L9743

@eytan-avisror eytan-avisror added the enhancement New feature or request label Jul 31, 2020
@eytan-avisror eytan-avisror added this to the 0.8.0 milestone Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants