Replace comma in default node names with semicolon

[jmholzer]

Resolves #2013

Description

Development notes

Checklist

• Read the contributing guidelines
• Opened this PR as a 'Draft Pull Request' if it is work-in-progress
• Updated the documentation to reflect the code changes
• Added a description of this change in the RELEASE.md file
• Added tests to cover my changes

[ankatiyar]

Minor comment - The error that is shown when you try to name a node with a string containing commas is ValueError: 'node, name' is not a valid node name. It must contain only letters, digits, hyphens, underscores and/or fullstops.. I think this could also possibly be modified to add semicolons for consistency.
Otherwise, looks good to me! 🎉

[merelcht]

This is a breaking change and should go on the develop branch. The ticket is tagged with the 0.19.0 version 🙂

[jmholzer]

Minor comment - The error that is shown when you try to name a node with a string containing commas is ValueError: 'node, name' is not a valid node name. It must contain only letters, digits, hyphens, underscores and/or fullstops.. I think this could also possibly be modified to add semicolons for consistency. Otherwise, looks good to me! 🎉

Thanks for the review! 😃 I think we might want to leave semicolons from this list, since if Kedro creates default node names with semicolons, that is an implicit statement that these names are correct. Currently, we do it differently; Kedro says that node names with commas are disallowed even though it also creates default node names with commas in them but I feel this is a bug (/ inconsistency) and not a feature.

[jmholzer]

This is a breaking change and should go on the develop branch. The ticket is tagged with the 0.19.0 version 🙂

Done 🙂

[merelcht]

LGTM! Don't forget to update the release notes to include this change.