Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change autogeneration of node names to not contain commas #2013

Closed
merelcht opened this issue Nov 9, 2022 · 1 comment · Fixed by #2087
Closed

Change autogeneration of node names to not contain commas #2013

merelcht opened this issue Nov 9, 2022 · 1 comment · Fixed by #2087
Assignees
@jmholzer
Labels
Component: CLI Issue/PR that addresses the CLI for Kedro

Comments

@merelcht
Copy link
Member

merelcht commented Nov 9, 2022

Description

Change how node names are generated to not contain commas. Currently we stringify a node's definition and set that as the node name if no name has been set explicitly: https://github.com/kedro-org/kedro/blob/main/kedro/pipeline/node.py#L239

Change is so that the generated name will contain the function name and output, where the outputs are separated by _ or - instead of ,.

So two_inputs([A0,B0]) -> [C1,C2] would become two_inputs -> [C1-C2]

Context

#1828
@merelcht merelcht added the Component: CLI Issue/PR that addresses the CLI for Kedro label Nov 9, 2022
@merelcht merelcht mentioned this issue Nov 9, 2022
Closed
@jmholzer jmholzer mentioned this issue Nov 30, 2022
Merged
5 tasks
@jmholzer jmholzer self-assigned this Nov 30, 2022
@jmholzer jmholzer moved this to In Progress in Kedro Framework Nov 30, 2022
@jmholzer jmholzer moved this from In Progress to In Review in Kedro Framework Nov 30, 2022
@jmholzer jmholzer mentioned this issue Nov 30, 2022
Closed
@merelcht
Copy link
Member Author

Completed in #2087

Repository owner moved this from In Review to Done in Kedro Framework Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmholzer jmholzer

Labels
Component: CLI Issue/PR that addresses the CLI for Kedro
Projects
Kedro Framework
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace comma in default node names with semicolon kedro-org/kedro
2 participants
@jmholzer @merelcht