Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowchart doesn't automatically reset the zoom when actions are performed. #1672

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

jitu5
Copy link
Contributor

@jitu5 jitu5 commented Dec 6, 2023

Resolves #1632

Description

This bug was introduced few months back in one of the enhancement ticket. now on any actions on flowchart it focus and reset as expected.

flowchart-zoom.mov

Development notes

QA notes

Please test it with metadata sidebar and code panel open and close combination.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@jitu5 jitu5 added the Javascript Pull requests that update Javascript code label Dec 6, 2023
@jitu5 jitu5 self-assigned this Dec 6, 2023
@jitu5 jitu5 requested a review from tynandebold as a code owner December 6, 2023 16:49
@ravi-kumar-pilla
Copy link
Contributor

Nice work Jitendra, This looks good and the zoom gets reset which was broken previously. But I wanted to understand, the use case where

  1. Zoom in to a modular pipeline
  2. Expand the modular pipeline to check individual nodes
  3. Should the zoom reset / zoom out ?
  4. I understand the reset which is happening when the pipeline dropdown selection changes and it looks good as below -

ddn_change

  1. But, when the user zooms in to a modular pipeline and expands, would it be nice not to zoom out ?

mod_pipeline_zoom_out

Thank you !

Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !!

Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!!

@jitu5 jitu5 merged commit 9fb0e85 into main Dec 11, 2023
5 checks passed
@jitu5 jitu5 deleted the fix/flowchart_zoom branch December 11, 2023 14:33
This was referenced Dec 18, 2023
rashidakanchwala added a commit that referenced this pull request Dec 19, 2023
Release 7.0.0

Major features and improvements

Upgrade to React 18. (Migrate to React 18 #1652)
Change CLI command to run Kedro-viz tokedro viz run. (Change 'Kedro Viz' to 'Kedro Viz Run' #1671)
Add deploy command to the CLI using kedro viz deploy for sharing Kedro-viz on AWS. (AWS focussed CLI implementation for Shareable Viz  #1661)
Add support for kedro==0.19and kedro-datasets==2.0. (Fix bug on kedro viz --load-file #1677)
Drop support for python=3.7. (Remove support for Python 3.7 #1660)
Drop support for kedro==0.17.x. (Drop Kedro 17  #1669)
Bug fixes and other changes
Fix modular pipelines breaking when collapsed on the flowchart. (Fix modular pipelines breaking when collapsed.  #1651)
Display hosted URL in CLI while launching Kedro viz. (Display hosted URL in CLI while launching kedro viz #1644)
Fix Kedro-viz display on Jupyter notebooks. (Fix Kedro-viz embedded as an IFrame #1658)
Fix zoom issues on the flowchart. (Flowchart doesn't automatically reset the zoom when actions are performed. #1672)
Fix bug on kedro-viz run --load-file. (Fix bug on kedro viz --load-file #1677)
Fix bug on adding timestamps to shareable-viz. (_#1679)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flowchart doesn't automatically reset the zoom when actions are performed
3 participants