-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Kedro 17 #1669
Drop Kedro 17 #1669
Conversation
Signed-off-by: Rashida Kanchwala <[email protected]>
Signed-off-by: Rashida Kanchwala <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small comments, but looks good! 👍
> **Note**: Kedro-Viz>=3.8.0 will not work with projects created with Kedro<=0.16.6. Please consider migrating your project to Kedro>=0.17.0 before you develop against the latest version of Kedro-Viz. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to remove this note now the other one is in place.
@@ -64,20 +61,9 @@ def _bootstrap(project_path: Path): | |||
"""Bootstrap the integration by running various Kedro bootstrapping methods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to keep this method? It's just the one way of bootstrapping now so you can also just call that directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work !! LGTM
Release 7.0.0 Major features and improvements Upgrade to React 18. (Migrate to React 18 #1652) Change CLI command to run Kedro-viz tokedro viz run. (Change 'Kedro Viz' to 'Kedro Viz Run' #1671) Add deploy command to the CLI using kedro viz deploy for sharing Kedro-viz on AWS. (AWS focussed CLI implementation for Shareable Viz #1661) Add support for kedro==0.19and kedro-datasets==2.0. (Fix bug on kedro viz --load-file #1677) Drop support for python=3.7. (Remove support for Python 3.7 #1660) Drop support for kedro==0.17.x. (Drop Kedro 17 #1669) Bug fixes and other changes Fix modular pipelines breaking when collapsed on the flowchart. (Fix modular pipelines breaking when collapsed. #1651) Display hosted URL in CLI while launching Kedro viz. (Display hosted URL in CLI while launching kedro viz #1644) Fix Kedro-viz display on Jupyter notebooks. (Fix Kedro-viz embedded as an IFrame #1658) Fix zoom issues on the flowchart. (Flowchart doesn't automatically reset the zoom when actions are performed. #1672) Fix bug on kedro-viz run --load-file. (Fix bug on kedro viz --load-file #1677) Fix bug on adding timestamps to shareable-viz. (_#1679)
Description
Kedro-viz should always support last 2 versions of Kedro. Given that Kedro 19 is releasing soon, we can stop supporting Kedro 17 from Kedro-viz 7.0.0 and only support Kedro>18
Development notes
QA notes
Checklist
RELEASE.md
file