Preview dataset #1288
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,9 @@ | |
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| PREVIEW_DATASETS = ["pandas.csv_dataset.CSVDataSet", | ||
| "pandas.parquet_dataset.ParquetDataSet", "pandas.excel_dataset.ExcelDataSet"] | ||
|
|
||
|
|
||
| def _pretty_name(name: str) -> str: | ||
| name = name.replace("-", " ").replace("_", " ").replace(":", ": ") | ||
|
|
@@ -555,13 +558,20 @@ class DataNodeMetadata(GraphNodeMetadata): | |
| # command to run the pipeline to this data node | ||
| run_command: Optional[str] = field(init=False, default=None) | ||
|
|
||
| preview: Optional[Dict] = field(init=False, default=None) | ||
|
|
||
| # TODO: improve this scheme. | ||
| def __post_init__(self, data_node: DataNode): | ||
| self.type = data_node.dataset_type | ||
| dataset = cast(AbstractDataSet, data_node.kedro_obj) | ||
| dataset_description = dataset._describe() | ||
| self.filepath = _parse_filepath(dataset_description) | ||
|
|
||
| if self.type in PREVIEW_DATASETS: | ||
| # If the kedro-datasets is on the latest and does have the _preview | ||
| if (hasattr(dataset, '_preview')): | ||
| self.preview = dataset._preview(40) | ||
|
There was a problem hiding this comment. Why not make this configurable here? There was a problem hiding this comment. Based on our telemetry, hardly anyone uses this. There was a problem hiding this comment. That's interesting. I would argue this is a slightly more compelling thing for users to actually change, but it's also something we can wait to see if users start asking for :) There was a problem hiding this comment. this is now done @datajoely 😄 I just included this today, by default this feature is always on unless user chooses to change it There was a problem hiding this comment. Is it toggled or can they pass the preview number of rows? There was a problem hiding this comment. it is just toggled on and off at the moment, with the number of rows sets to 40 |
||
|
|
||
| # Run command is only available if a node is an output, i.e. not a free input | ||
| if not data_node.is_free_input: | ||
| self.run_command = f"kedro run --to-outputs={data_node.full_name}" | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import PreviewTable from './preview-table'; | ||
|
|
||
| export default PreviewTable; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import React from 'react'; | ||
| import className from 'classnames'; | ||
|
|
||
| import './preview-table.css'; | ||
|
|
||
| const PreviewTable = ({ data, size = 'small' }) => { | ||
| const headers = Object.keys(data); | ||
Huongg marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| const nRows = Object.keys(data[headers[0]]); | ||
Huongg marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| return ( | ||
| <table | ||
| className={className('preview-table', { | ||
| 'preview-table__small': size === 'small', | ||
| 'preview-table__large': size === 'large', | ||
| })} | ||
| cellSpacing={0} | ||
| > | ||
| <tbody> | ||
| <tr className="preview-table__row-header"> | ||
| {headers.map((header) => ( | ||
| <th className="preview-table__header" key={header}> | ||
| {header} | ||
| </th> | ||
| ))} | ||
| </tr> | ||
| {nRows.map((index) => ( | ||
| <tr className="preview-table__row" key={index}> | ||
| {headers.map((header, i) => { | ||
| return ( | ||
| <td className="preview-table__data" key={i}> | ||
| {data[header][index]} | ||
| </td> | ||
| ); | ||
| })} | ||
| </tr> | ||
| ))} | ||
| </tbody> | ||
| </table> | ||
| ); | ||
| }; | ||
|
|
||
| export default PreviewTable; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| @use '../../styles/variables' as variables; | ||
| @use '../../styles/extends'; | ||
|
|
||
| .kui-theme--light { | ||
| --color-highlight: #{variables.$grey-200}; | ||
| } | ||
|
|
||
| .kui-theme--dark { | ||
| --color-highlight: #{variables.$slate-400}; | ||
| } | ||
|
|
||
| .preview-table__header { | ||
| font-size: 12px; | ||
| font-weight: 600; | ||
| line-height: 16px; | ||
| padding-bottom: 12px; | ||
| } | ||
|
|
||
| .preview-table__data { | ||
| font-size: 12px; | ||
| font-weight: 400; | ||
| line-height: 16px; | ||
| padding-bottom: 8px; | ||
| } | ||
|
|
||
| .preview-table__small { | ||
| margin: 30px 32px; | ||
|
|
||
| .preview-table__header, | ||
| .preview-table__data { | ||
| text-align: left; | ||
| padding-right: 32px; | ||
| } | ||
| } | ||
|
|
||
| .preview-table__large { | ||
| margin: auto 30px 30px auto; | ||
|
|
||
| .preview-table__header, | ||
| .preview-table__data { | ||
| padding: 12px 42px 12px 22px; | ||
| text-align: left; | ||
| } | ||
| } | ||
|
|
||
| .preview-table__row:hover { | ||
| background: var(--color-highlight); | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| .preview-table__header, | ||
| .preview-table__data { | ||
| position: relative; | ||
| outline: 0; | ||
| } | ||
|
|
||
| .preview-table__header:hover { | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| .preview-table__header:hover::after { | ||
| background: var(--color-highlight); | ||
| content: ''; | ||
| height: 100vh; | ||
| left: 0; | ||
| position: absolute; | ||
| top: -12px; | ||
| width: 95%; | ||
| z-index: -1; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supporting Spark and launch would be a really nice stretch goal, but not a dealbreaker