-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview dataset #1288
Merged
Merged
Preview dataset #1288
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
007f7c2
set up preview in response and flowchart.py
Huongg 0ff46cf
return preview for metaData
Huongg e469560
filter data and render the table
Huongg 38e641c
add preview-table component
Huongg 4fd5136
fix styling for table in metadata panel
Huongg 6ca4ec4
add previewTable to metadata-modal
Huongg 36931d0
different theme for preview table
Huongg 2abe3a6
add classname for preview-table
Huongg 85dda7c
add size for PreviewTable
Huongg 6aa6b6e
add cursor pointer
Huongg 9a6eae7
styling for row hover state
Huongg dc19dd1
light and dark theme for hovering
Huongg d41b4f6
include excel and parquet dataset
Huongg 5d775cf
Merge branch 'main' of github.com:kedro-org/kedro-viz into preview-da…
Huongg 6e143f9
add margin for table large
Huongg de652bd
check if self.type is in preview_datasets
Huongg 20bcefd
remove preview table style
Huongg 6a90f53
add preview text
Huongg a7c07b0
Adding test for preview table
Huongg e7b1a56
adding condition to not call _preview if not existed
Huongg 2ce39d0
move the hasAttr inside the previewDataSet loops
Huongg c6ec97a
update light theme colour for highlighting
Huongg 0a6c107
onclick handler when clicking on small table
Huongg 4c4a2a1
update release note
Huongg 7990f5a
remove highlighting row in small table
Huongg 3d1de36
update previewing message
Huongg 1f578a5
update variable names
Huongg e5fab1d
pull changes from remote branch
Huongg 15e61d4
Merge branch 'main' into preview-dataset
Huongg 9869229
ignore updateContent file
Huongg bc7a12c
formatting
Huongg a772729
test_data_node_metadata_preview for flowchart.py
Huongg ed13b44
remove parquet dataset preview
Huongg bc25c3e
restructure data in preview table
Huongg e446fdd
update name to onExpandMetaDataClick
Huongg c726a7b
restructure the flowchart.py for _preview
Huongg 36b7c66
update test to reflect the new data structure
Huongg 3658109
adding test for flowchart.py
Huongg 538cf9c
downgrade mypy package
Huongg 63b0b7d
formatting
Huongg 4f558c7
include # pylint: disable=attr-defined for _preview
Huongg 8d5ed2a
include # type: ignore
Huongg 1244076
include ignore in response
Huongg e3f7924
update wrong test name
Huongg 9b89c6c
sticky header for preview table
Huongg 0455310
feature flag and connect the preview data with config table
Huongg 3d54783
use more generic classname for metadata modal
Huongg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth putting this at the top of the list since to users it's much more interesting than the other changes 😀 (maybe the react version point should go under bug fixes and other changes?)
Maybe also worth saying "preview of
pandas.CSVDataSet
andpandas.ExcelDataSet
" too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey i like the idea of including the "preview of pandas.CSVDataSet and pandas.ExcelDataSet" here too. Even though it will also mention it in our Release highlight in the UI, I guess no harm to mention here again.
I think the React version might be a major change actually but maybe @tynandebold can confirm this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The React version change will make this a major release, so probably ok to leave it where it is.