Update comments and suggested defaults #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't created an issue, as it seems to be an easy fix. However, if that's the proper workflow, and if these changes are worth going forward, I can do that. |
|
It seems like documentation was not updated on this MR, so you will see one related line being removed in this MR. |
|
Could you sign the commit please? |
Signed-off-by: Kamil Aliev <[email protected]>
|
Now done :) |
zroubalik
approved these changes
Jun 27, 2024
JorTurFer
pushed a commit
to JorTurFer/charts
that referenced
this pull request
Jul 31, 2024
Signed-off-by: Kamil Aliev <[email protected]>
JorTurFer
pushed a commit
to JorTurFer/charts
that referenced
this pull request
Jul 31, 2024
Signed-off-by: Kamil Aliev <[email protected]> Signed-off-by: Jorge Turrado <[email protected]>
JorTurFer
added a commit
that referenced
this pull request
Jul 31, 2024
* fix: labels on cloudeventsources CRD should be the same as other CRDs (#656) Signed-off-by: Joel Dimbernat <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * chore: Update comments and suggested defaults (#651) Signed-off-by: Kamil Aliev <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * fix: broken "| default" logic for automountServiceAccountToken (#665) When setting (.Values.serviceAccount.operator).automountServiceAccountToken to boolean false, the "| default" part kicks in. Fix is strongly inspired from helm/helm#12080 (comment) Signed-off-by: François Blondel <[email protected]> Co-authored-by: François Blondel <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * fix: add forgotten crds.additionalAnnotations to crd-cloudeventsources.yaml (#668) Signed-off-by: François Blondel <[email protected]> Co-authored-by: François Blondel <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * Prepare release v2.14.3 Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Joel Dimbernat <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Kamil Aliev <[email protected]> Signed-off-by: François Blondel <[email protected]> Co-authored-by: JoelDimbernat <[email protected]> Co-authored-by: Kamil Aliev <[email protected]> Co-authored-by: François Blondel <[email protected]> Co-authored-by: François Blondel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that currently the description about root affinity setting is not correct, based on template here.
Also I assume that suggested root affinity would like to split all components across the nodes, not only operator and metrics-server.
Lastly for consistency I applied name of the admissions webhook to its affinity suggestion to follow similar suggestions for operator and metrics-server.
Checklist