Skip to content

Commit

Permalink
chore: Update comments and suggested defaults (#651)
Browse files Browse the repository at this point in the history
Signed-off-by: Kamil Aliev <[email protected]>
  • Loading branch information
kamialie authored Jun 27, 2024
1 parent 3b04c40 commit 8a1ad4e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
3 changes: 1 addition & 2 deletions keda/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ their default values.
|-----------|------|---------|-------------|
| `additionalAnnotations` | object | `{}` | Custom annotations to add into metadata |
| `additionalLabels` | object | `{}` | Custom labels to add into metadata |
| `affinity` | object | `{}` | [Affinity] for pod scheduling for both KEDA operator and Metrics API Server |
| `affinity` | object | `{}` | [Affinity] for pod scheduling for KEDA operator, Metrics API Server and KEDA admission webhooks. |
| `asciiArt` | bool | `true` | Capability to turn on/off ASCII art in Helm installation notes |
| `certificates.autoGenerated` | bool | `true` | Enables the self generation for KEDA TLS certificates inside KEDA operator |
| `certificates.certManager.caSecretName` | string | `"kedaorg-ca"` | Secret name where the CA is stored (generatedby cert-manager or user given) |
Expand Down Expand Up @@ -95,7 +95,6 @@ their default values.
| `networkPolicy.enabled` | bool | `false` | Enable network policies |
| `networkPolicy.flavor` | string | `"cilium"` | Flavor of the network policies (cilium) |
| `nodeSelector` | object | `{}` | Node selector for pod scheduling ([docs](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/)) |
| `podIdentity.activeDirectory.identity` | string | `""` | Identity in Azure Active Directory to use for Azure pod identity |
| `podIdentity.aws.irsa.audience` | string | `"sts.amazonaws.com"` | Sets the token audience for IRSA. This will be set as an annotation on the KEDA service account. |
| `podIdentity.aws.irsa.enabled` | bool | `false` | Specifies whether [AWS IAM Roles for Service Accounts (IRSA)](https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts.html) is to be enabled or not. |
| `podIdentity.aws.irsa.roleArn` | string | `""` | Set to the value of the ARN of an IAM role with a web identity provider. This will be set as an annotation on the KEDA service account. |
Expand Down
5 changes: 3 additions & 2 deletions keda/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ webhooks:
# - key: app
# operator: In
# values:
# - keda-operator
# - keda-admission-webhooks
# topologyKey: "kubernetes.io/hostname"

# -- [Failure policy](https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#failure-policy) to use with KEDA admission webhooks
Expand Down Expand Up @@ -512,7 +512,7 @@ topologySpreadConstraints:
# -- [Pod Topology Constraints] of KEDA admission webhooks pod
webhooks: []

# -- [Affinity] for pod scheduling for both KEDA operator and Metrics API Server
# -- [Affinity] for pod scheduling for KEDA operator, Metrics API Server and KEDA admission webhooks.
affinity: {}
# podAntiAffinity:
# requiredDuringSchedulingIgnoredDuringExecution:
Expand All @@ -523,6 +523,7 @@ affinity: {}
# values:
# - keda-operator
# - keda-operator-metrics-apiserver
# - keda-admission-webhooks
# topologyKey: "kubernetes.io/hostname"

# -- priorityClassName for all KEDA components
Expand Down

0 comments on commit 8a1ad4e

Please sign in to comment.