Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/eslint #109

Merged
merged 8 commits into from
Mar 6, 2024
Merged

Feature/eslint #109

merged 8 commits into from
Mar 6, 2024

Conversation

shellyear
Copy link
Collaborator

Implementing eslint incrementally in this PR, considering discussion here

@blcham
Copy link

blcham commented Mar 6, 2024

Not sure if i was supposed to check this but if npm run validate i get following error:
image

@blcham blcham mentioned this pull request Mar 6, 2024
4 tasks
@shellyear
Copy link
Collaborator Author

Not sure if i was supposed to check this but if npm run validate i get following error: image

I forgot to push the changes yesterday to the remote, now it should work

Copy link

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets discuss it in a while, you can answer some of the questions and some harder to explain leave for the meeting.

src/components/user/User.jsx Show resolved Hide resolved
.eslintrc.cjs Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/HorizontalInput.jsx Show resolved Hide resolved
src/components/Input.jsx Show resolved Hide resolved
src/components/institution/Institution.jsx Show resolved Hide resolved
src/components/login/Login.jsx Show resolved Hide resolved
src/components/user/PasswordChange.jsx Show resolved Hide resolved
src/components/user/User.jsx Show resolved Hide resolved
vite.config.js Show resolved Hide resolved
@blcham
Copy link

blcham commented Mar 6, 2024

@shellyear please

  • create ticket for warnings that eslint generates !
  • make sure that application works

@shellyear shellyear mentioned this pull request Mar 6, 2024
3 tasks
@shellyear
Copy link
Collaborator Author

shellyear commented Mar 6, 2024

  • create ticket for warnings that eslint generates !
    *it means not the potential errors(if we use some plugins like airbnb), but the actual ones, that I see when running npm run lint(mainly css related warnings)

@shellyear shellyear mentioned this pull request Mar 6, 2024
5 tasks
@shellyear
Copy link
Collaborator Author

shellyear commented Mar 6, 2024

@shellyear please

  • create ticket for warnings that eslint generates !
  • make sure that application works

The ticket with warnings is here
The application works fine, with warnings defined in the mentioned issue

@blcham
Copy link

blcham commented Mar 6, 2024

Merging, congrats 🥳🥳🥳

@blcham blcham merged commit df439d4 into kbss-cvut:main Mar 6, 2024
2 checks passed
@blcham
Copy link

blcham commented Mar 6, 2024

@LaChope this PR was merged, there are 48 files changed mostly only additions, so I suggest that you rebase your work ASAP so you do not have to merge to much later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants