Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #110

Open
3 tasks
blcham opened this issue Mar 6, 2024 · 4 comments · Fixed by #130
Open
3 tasks

Fix tests #110

blcham opened this issue Mar 6, 2024 · 4 comments · Fixed by #130
Assignees

Comments

@blcham
Copy link

blcham commented Mar 6, 2024

Since mirgration to Vite, we had to disable tests. We need to enable them again.

See package.json:
"test": "echo !!!tests are disabled!!!",

A/C:

@shellyear
Copy link
Collaborator

shellyear commented Mar 6, 2024

mentioned here

@shellyear
Copy link
Collaborator

shellyear commented Mar 11, 2024

@blcham When using jest with Vite, it comes with some limitations, another way is to use babel.config.js to avoid limitations

@shellyear
Copy link
Collaborator

@blcham

Vitest: Lightweight, fast, flexible and well documented, but has limited number of features comparing to RTL and lesser community, but it is a part of vite ecosystem. Migration guide is here. I think this should be good for smaller projects and has limited features

RTL(react-testing-library): Accessibility Testing (encourages testing from the user's perspective),it is officially supported by React team, integratable with Jest, has extensive docs, and much bigger community. It is more robust(test may be slow), and comes with its learning curve

@blcham
Copy link
Author

blcham commented Mar 28, 2024

I believe thanks to #130 the only requirements solved now are :

  • tests are enabled
  • all tests are passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants