-
-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed #478 #518
fixed #478 #518
Conversation
@kazupon also, quoting CircleCI, |
Codecov Report
@@ Coverage Diff @@
## dev #518 +/- ##
=======================================
Coverage 96.75% 96.75%
=======================================
Files 9 9
Lines 679 679
=======================================
Hits 657 657
Misses 22 22
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## dev #518 +/- ##
=======================================
Coverage 96.75% 96.75%
=======================================
Files 9 9
Lines 679 679
=======================================
Hits 657 657
Misses 22 22
Continue to review full report at Codecov.
|
Oh, and for the context:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 👍
Thanks!
Essentially, going into link phase triggers additional cycle of interpolation(one outside of linking phase as usual, and one more inside) which leads to weird results.
The fix is pretty simple(and looking at the code, even thought of originally): switch mode to
raw
for the linking phase.@kazupon Note:
Prior to this fix, 2 tests already failed on my setup:
Not sure if those are known problems or if I should report them.