Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #478 #518

Merged
merged 2 commits into from
Feb 10, 2019
Merged

fixed #478 #518

merged 2 commits into from
Feb 10, 2019

Conversation

stroncium
Copy link
Contributor

Essentially, going into link phase triggers additional cycle of interpolation(one outside of linking phase as usual, and one more inside) which leads to weird results.

The fix is pretty simple(and looking at the code, even thought of originally): switch mode to raw for the linking phase.

@kazupon Note:
Prior to this fix, 2 tests already failed on my setup:

  • test/unit/datetime.test.js:50 - looks like timezone mismatch
  • test/unit/number.test.js:58 - missing space

Not sure if those are known problems or if I should report them.

@stroncium
Copy link
Contributor Author

@kazupon also, quoting CircleCI, Warning: Your project is using CircleCI 1.0 and will stop building on March 15, 2019. Update remaining projects to CircleCI 2.0 to continue building.

@codecov-io
Copy link

Codecov Report

Merging #518 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #518   +/-   ##
=======================================
  Coverage   96.75%   96.75%           
=======================================
  Files           9        9           
  Lines         679      679           
=======================================
  Hits          657      657           
  Misses         22       22
Impacted Files Coverage Δ
src/index.js 99.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a3377...9627d12. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Feb 10, 2019

Codecov Report

Merging #518 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #518   +/-   ##
=======================================
  Coverage   96.75%   96.75%           
=======================================
  Files           9        9           
  Lines         679      679           
=======================================
  Hits          657      657           
  Misses         22       22
Impacted Files Coverage Δ
src/index.js 99.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a3377...d7aa68b. Read the comment docs.

@stroncium
Copy link
Contributor Author

stroncium commented Feb 10, 2019

Oh, and for the context:

  • link phase will treat raw by switching to string and disabling values for underlying phases
  • render phase will obviously still run after linking phase, handling all the interpolations
  • there are some more precise and invasive methods of fixing this, but I decided to stay on the side of least impact/changes, but if needed i can go deeper into it
  • I added a test to ensure links to links still work properly

Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants