Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linked message translates the translated message #478

Closed
metalanti opened this issue Dec 6, 2018 · 15 comments · May be fixed by tt9133github/snyktest#3
Closed

linked message translates the translated message #478

metalanti opened this issue Dec 6, 2018 · 15 comments · May be fixed by tt9133github/snyktest#3
Labels
good first issue Good for newcomers help wanted Extra attention is needed Type: Bug Bug or Bug fixes

Comments

@metalanti
Copy link

vue & vue-i18n version

2.5.17, 8.4.0

I dont know if it is the expected behavior
the linked message translates the translated message

Reproduction

{
  "hello": "Hello {name}",
  "linkedHello": "@:hello"
}

<p>{{ $t('hello', { name: 'World {text}' }) }}</p> - good
<p>{{ $t('hello', { name: 'World {text}', text: 'something' }) }}</p> - good

<p>{{ $t('linkedHello', { name: 'World {text}' }) }}</p> - bad
<p>{{ $t('linkedHello', { name: 'World {text}', text: 'something' }) }}</p> - bad

What is Expected?

<p>Hello World {text}</p>

What is actually happening?

<p>Hello World {text}</p> - good
<p>Hello World {text}</p> - good

<p>Hello World </p> - bad
<p>Hello World something</p> - bad

@kazupon kazupon added Type: Bug Bug or Bug fixes help wanted Extra attention is needed good first issue Good for newcomers IssueHuntFest labels Dec 14, 2018
@IssueHuntBot
Copy link

@kazupon has funded $30.00 to this issue. See it on IssueHunt

@kimuraz
Copy link
Contributor

kimuraz commented Dec 18, 2018

@kazupon may I get this one too? 😬

@kazupon
Copy link
Owner

kazupon commented Dec 18, 2018

@kimuraz
You can contribute :)

@IssueHuntBot
Copy link

@kazupon has funded $30.00 to this issue. See it on IssueHunt

@rahgurung
Copy link

No activity since 10 days, can I take it ?

@kazupon
Copy link
Owner

kazupon commented Jan 6, 2019

@gurungrahul2
sure!

@kazupon
Copy link
Owner

kazupon commented Jan 6, 2019

@gurungrahul2
sorry, please wait.

@kimuraz
Are you still challenging this issue?

@kimuraz
Copy link
Contributor

kimuraz commented Jan 9, 2019

@kazupon
I actually made some changes, but I really couldn't keep going for a while, I think @gurungrahul2 can take it... sorry for bothering and for the late reply

@kazupon
Copy link
Owner

kazupon commented Jan 9, 2019

@kimuraz
Thank you for you contributing!
okay, no worry :)

@gurungrahul2
You can do it!

@rahgurung
Copy link

@kazupon how can I test if my changes fix the issue, how can i re-build vue with my changes and import to my web page ?

@kazupon
Copy link
Owner

kazupon commented Jan 15, 2019

@gurungrahul2
You can contribute by contribution guide.

@rahgurung
Copy link

@kazupon but it still doesn't answer my doubt.

@kimuraz
Copy link
Contributor

kimuraz commented Jan 20, 2019

@gurungrahul2 I migth have something on my old attempt...

kimuraz@e3c11c0

@exoego
Copy link
Collaborator

exoego commented Jan 20, 2019

how can I test if my changes fix the issue

Refer development setup.
https://github.com/kazupon/vue-i18n/blob/dev/CONTRIBUTING.md#development-setup

It tells how to setup test environment and how to run tests.

how can i re-build vue with my changes and import to my web page ?

Do you mean: you want to test new changes added to vue-i18n (not vue) on your web page?

  1. npm run build
  2. Find the new vue-i18n.js built in dist directory.
  3. Upload it to your web page and test manually.

But you don't need to do so.
vue-i18n has end-2-end test which runs tests on web browser using Selenium.
If you add new tests (and maybe updating existing tests), Selenium runs tests on browsers automatically.

@IssueHuntBot
Copy link

@kazupon has rewarded $42.00 to @stroncium. See it on IssueHunt

  • 💰 Total deposit: $60.00
  • 🎉 Repository reward(20%): $12.00
  • 🔧 Service fee(10%): $6.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants