-
Notifications
You must be signed in to change notification settings - Fork 196
ci: Test install kata-runtime in "No GO command or GOPATH not set" mode #1234
Conversation
/test |
build "${github_project}" "${make_target}" | ||
pushd "${GOPATH}/src/${github_project}" | ||
if [ "$test_not_gopath_set" = "true" ]; then | ||
info "Installing ${github_project} in GOPATH not set mode" | ||
sudo -E KATA_RUNTIME="${KATA_RUNTIME}" make install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GOPATH
is set on line 91 and you're using sudo -E
so isn't GOPATH
set here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it found the issue of "GOPATH not set mode".
I need to fix it in runtime first.
kata-containers/runtime#1286
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't understand this - GOPATH
is set here so how can it be "No GO command or GOPATH not set mode" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jodh-intel This part use:
sudo -E KATA_RUNTIME="${KATA_RUNTIME}" make install
without
PATH="$PATH"
Then no go command can work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh! I always read -E
as "export the entire env" rather than "export the vars you give me" 😄
/test |
Add a test to install kata-runtime in "No GO command or GOPATH not set" mode. Fixes: kata-containers#1233 Signed-off-by: Hui Zhu <[email protected]>
/test |
jenkins-metrics-ubuntu-16-04 failed:
This pr doesn't change the default behavior of kata-runtime. |
Hi @teawater - I 'adjusted' the metrics CI yesterday, so hopefully it is more stable. I have nudged a rebuild of that job, but indeed, this PR should not affect metrics. |
@jodh-intel @devimc - pls re-review |
Add a test to install kata-runtime in "No GO command or GOPATH not set" mode.
Fixes: #1233
Signed-off-by: Hui Zhu [email protected]