Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

ci: Test install kata-runtime in "No GO command or GOPATH not set" mode #1234

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

teawater
Copy link
Member

@teawater teawater commented Feb 25, 2019

Add a test to install kata-runtime in "No GO command or GOPATH not set" mode.

Fixes: #1233

Signed-off-by: Hui Zhu [email protected]

.ci/install_runtime.sh Outdated Show resolved Hide resolved
@teawater
Copy link
Member Author

/test

build "${github_project}" "${make_target}"
pushd "${GOPATH}/src/${github_project}"
if [ "$test_not_gopath_set" = "true" ]; then
info "Installing ${github_project} in GOPATH not set mode"
sudo -E KATA_RUNTIME="${KATA_RUNTIME}" make install
Copy link
Contributor

@jodh-intel jodh-intel Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOPATH is set on line 91 and you're using sudo -E so isn't GOPATH set here?

Copy link
Member Author

@teawater teawater Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it found the issue of "GOPATH not set mode".
I need to fix it in runtime first.
kata-containers/runtime#1286

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't understand this - GOPATH is set here so how can it be "No GO command or GOPATH not set mode" ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jodh-intel This part use:

sudo -E KATA_RUNTIME="${KATA_RUNTIME}" make install

without

PATH="$PATH"

Then no go command can work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! I always read -E as "export the entire env" rather than "export the vars you give me" 😄

@teawater teawater changed the title ci: Test install kata-runtime in in GOPATH not set mode ci: Test install kata-runtime in "No GO command or GOPATH not set" mode Mar 4, 2019
@teawater
Copy link
Member Author

teawater commented Mar 4, 2019

/test

Add a test to install kata-runtime in "No GO command or GOPATH not set" mode.

Fixes: kata-containers#1233

Signed-off-by: Hui Zhu <[email protected]>
@teawater
Copy link
Member Author

teawater commented Mar 4, 2019

/test

@teawater
Copy link
Member Author

teawater commented Mar 6, 2019

jenkins-metrics-ubuntu-16-04 failed:

Report Summary:
+-----+----------------------+-------+-------+--------+-------+-------+--------+-------+------+-----+
| P/F |         NAME         |  FLR  | MEAN  |  CEIL  |  GAP  |  MIN  |  MAX   |  RNG  | COV  | ITS |
+-----+----------------------+-------+-------+--------+-------+-------+--------+-------+------+-----+
| P   | boot-times           | 95.0% | 99.7% | 105.0% | 10.0% | 92.5% | 104.8% | 13.4% | 3.6% |  20 |
| *F* | memory-footprint     | 95.0% | 92.9% | 105.0% | 10.0% | 92.9% | 92.9%  | 0.0%  | 0.0% |   1 |
| *F* | memory-footprint-ksm | 95.0% | 69.5% | 105.0% | 10.0% | 69.5% | 69.5%  | 0.0%  | 0.0% |   1 |
+-----+----------------------+-------+-------+--------+-------+-------+--------+-------+------+-----+
Fails: 2, Passes 1
Failed
checkmetrics FAILED (1)
restoring KSM settings
Build step 'Execute shell' marked build as failure

This pr doesn't change the default behavior of kata-runtime.
So I think this pr does not relate to this fail.

@grahamwhaley
Copy link
Contributor

Hi @teawater - I 'adjusted' the metrics CI yesterday, so hopefully it is more stable. I have nudged a rebuild of that job, but indeed, this PR should not affect metrics.

@grahamwhaley
Copy link
Contributor

@jodh-intel @devimc - pls re-review

@devimc devimc merged commit d0d0038 into kata-containers:master Mar 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants