-
Notifications
You must be signed in to change notification settings - Fork 374
Makefile: Change "GOPATH not set" to "No GO command" #1286
Conversation
/test |
Makefile
Outdated
@@ -12,8 +12,10 @@ for file in /etc/os-release /usr/lib/os-release; do \ | |||
fi \ | |||
done) | |||
|
|||
HAVEGO=$(shell go version 2>/dev/null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already used in golang.mk
so why not use that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jodh-intel Thanks for your remind.
I pushed a new version that replaces HAVEGO to golang_version_raw.
This PR doesn't change the default running behavior of kata-runtime. |
/test |
$ (unset GOPATH; go version;make)
go version go1.11.5 linux/amd64
INFO: yq was not found, installing it
make: /bin/yq: Command not found
golang.mk:30: *** "ERROR: cannot determine minimum golang version". Arrêt. The problem is that Personally, I'd just set |
/test |
@jodh-intel Both "GOPATH not set" or "No GO command" will make kata-runtime build failed now. |
jenkins-ci-ARM-ubuntu-18-04 failed
This PR doesn't change the behavior of kata-runtime execution. So it has nothing to do with this failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The cause that make "sudo make install" fail is not "GOPATH not set", but no go command in path. But the commit still keep the "GOPATH not set" because execute "unset GOPATH; make" will fail because "go build" cannot work without GOPATH. Fixes: kata-containers#1285 Signed-off-by: Hui Zhu <[email protected]>
/test |
lgtm |
The cause that make "sudo make install" fail is not "GOPATH not set",
but no go command in path.
But the commit still keep the "GOPATH not set" because
execute "unset GOPATH; make" will fail because "go build" cannot work
without GOPATH.