This repository has been archived by the owner on May 12, 2021. It is now read-only.
store: Add SetLogger API #1298
Merged
store: Add SetLogger API #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `store.SetLogger()` API to allow the store package to log with the standard set of fields (as expected by the log parser [1]. Fixes kata-containers#1297. --- [1] - https://github.com/kata-containers/tests/tree/master/cmd/log-parser#logfile-requirements Signed-off-by: James O. D. Hunt <[email protected]>
|
/test |
devimc
approved these changes
Feb 28, 2019
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
store.SetLogger()API to allow the store package to log with the standard set of fields (as expected by the log parser [1].Fixes #1297.
[1] - https://github.com/kata-containers/tests/tree/master/cmd/log-parser#logfile-requirements
Signed-off-by: James O. D. Hunt [email protected]