[WIP] Break the hypervisor dependency from the endpoint interface #1233
Conversation
We are going to convert the Endpoint interface to have it return Devices instead of relying on the hypervisor interface itself. Fixes: kata-containers#1209 Signed-off-by: Samuel Ortiz <[email protected]>
Removing and adding devices only take a types.Device argument. Fixes: kata-containers#1209 Signed-off-by: Samuel Ortiz <[email protected]>
| addDevice(devInfo interface{}, devType types.DeviceType) error | ||
| hotplugAddDevice(devInfo interface{}, devType types.DeviceType) (interface{}, error) | ||
| hotplugRemoveDevice(devInfo interface{}, devType types.DeviceType) (interface{}, error) | ||
| addDevice(types.Device) error |
There was a problem hiding this comment.
Can you elaborate how this change will help decouple the hypervisor from the endpoint dependency?
From what I understand here, we're simply moving the device info as part of the device structure itself, but the detection of the device types such as Endpoint is still happening inside each hypervisor implementation, right?
|
Ping @kata-containers/runtime - ...! |
|
@sameo - one file conflict to resolve. |
|
The Attach() for an endpoint stills invokes the hypervisor. How does this break the dependency on the hypervisor package? |
|
@sameo any updates? Ping. Thx! |
|
@sameo nudge |
|
@sameo any updates? Thx. |
egernst
added
needs-rebase
|
Any takers? 😄 |
|
Revisiting, any takers? 😄 |
|
Any takers? Your weekly Kata herder. |
|
Ping for any takers 😄 |
|
Ping 😄 Kata Herder. |
|
@jodh-intel this is old, should we close this and move the work to 2.0? |
|
As this PR is marked as do-not-merge, we're assuming it won't make for the final 1.13.0 release, thus we're closing it. |
Fixes: #1209