Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

[disscuss] Should we need something like QEMU_VERSION? #615

Closed
Weichen81 opened this issue Aug 21, 2018 · 2 comments
Closed

[disscuss] Should we need something like QEMU_VERSION? #615

Weichen81 opened this issue Aug 21, 2018 · 2 comments

Comments

@Weichen81
Copy link
Contributor

Description of problem

In these days, we are fixing a bug #584 that is caused by QEMU max VCPU number. And I found the max VCPU number for different QEMU versions are different. For QEMU 2.11 or 2.12 stable version. On Arm64 host with GICv3 support, the QEMU can support to 123 VCPUs. But in latest upstream/master code, the QEMU support 123 + 512 VCPUs.
In this case, should we need an environment like QEMU_VERSION for us to make code be more flexible? Because we don't force user to use specific QEMU version.

@Pennyzct @jodh-intel @bergwolf

@devimc
Copy link

devimc commented Aug 21, 2018

Should we need something like QEMU_VERSION?

I don't think so, see: https://github.com/kata-containers/runtime/blob/master/virtcontainers/qemu.go#L82-L83

@Weichen81
Copy link
Contributor Author

@devimc Thank you! I will use these two variables.

egernst pushed a commit to egernst/runtime that referenced this issue Feb 9, 2021
Some containers may require HW devices to improve its performance. In Kata
containers these devices can be passed though VFIO and used in the container
only if the guest kernel has the drivers built-in for them. When kernel
fragment support landed (kata-containers/packaging#646), kata lost support
for several HW devices like Intel GPUs, this was expected since one of the
goals of this change was to have a minimal kernel in order to improve boot
time, memory footprint and reduce the attack surface by enabling just the
features required to run kata containers.
Currently if the users want to use a HW device in kata container, He/She has
to build a custom kernel and create a custom image that includes the modules
that will be loaded by systemd. From user's perspective this is a pain, since
not all users know how to create a custom image or configure/build a custom
kernel.
Same as the `debug_console` feature (kata-containers/agent#547), the goal of
this change is to facilitate the things to the final user and *do not* depend
on systemd.
The list of kernel modules and their parameters are set through gRPC when the
sandbox is created.

fixes kata-containers#615

see kata-containers/osbuilder#77

Signed-off-by: Julio Montes <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants