Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

qemu: refactor maximum vcpus supported in aarch64 #584

Closed
Pennyzct opened this issue Aug 15, 2018 · 0 comments
Closed

qemu: refactor maximum vcpus supported in aarch64 #584

Pennyzct opened this issue Aug 15, 2018 · 0 comments
Assignees

Comments

@Pennyzct
Copy link
Contributor

Description of problem

on aarch64, we support different gic interrupt controllers.The maximum number of vCPUs depends on the GIC version, or on how many redistributors we can fit into the memory map.

Expected result

run succressfully

Actual result

if kata was running in ThunderX II which contains 224 cpu cores, the outputs were as follows:
docker: Error response from daemon: OCI runtime create failed: qemu-system-aarch64: Number of SMP CPUs requested (224) exceeds max CPUs supported by machine 'mach-virt' (123): unknown
relevant PR will upload asap.
@Weichen81

Pennyzct added a commit to Pennyzct/runtime that referenced this issue Aug 15, 2018
on aarch64, we support different gic interrupt controllers.
The maximum number of vCPUs depends on the GIC version, or on how
many redistributors we can fit into the memory map.

Fixes: kata-containers#584

Signed-off-by: Penny Zheng <[email protected]>
igned-off-by: Wei Chen <[email protected]>
Pennyzct added a commit to Pennyzct/runtime that referenced this issue Aug 15, 2018
on aarch64, we support different gic interrupt controllers.
The maximum number of vCPUs depends on the GIC version, or on how
many redistributors we can fit into the memory map.

Fixes: kata-containers#584

Signed-off-by: Penny Zheng <[email protected]>
Signed-off-by: Wei Chen <[email protected]>
Pennyzct added a commit to Pennyzct/runtime that referenced this issue Aug 17, 2018
on aarch64, we support different gic interrupt controllers.
The maximum number of vCPUs depends on the GIC version, or on how
many redistributors we can fit into the memory map.

Fixes: kata-containers#584

Signed-off-by: Penny Zheng <[email protected]>
Signed-off-by: Wei Chen <[email protected]>
Pennyzct added a commit to Pennyzct/runtime that referenced this issue Aug 27, 2018
on aarch64, we support different gic interrupt controllers.
The maximum number of vCPUs depends on the GIC version, or on how
many redistributors we can fit into the memory map.

Fixes: kata-containers#584

Signed-off-by: Penny Zheng <[email protected]>
Signed-off-by: Wei Chen <[email protected]>
Pennyzct added a commit to Pennyzct/runtime that referenced this issue Aug 29, 2018
on aarch64, we support different gic interrupt controllers.
The maximum number of vCPUs depends on the GIC version, or on how
many redistributors we can fit into the memory map.

Fixes: kata-containers#584

Signed-off-by: Penny Zheng <[email protected]>
Signed-off-by: Wei Chen <[email protected]>
Pennyzct added a commit to Pennyzct/runtime that referenced this issue Sep 3, 2018
on aarch64, we support different gic interrupt controllers.
The maximum number of vCPUs depends on the GIC version, or on how
many redistributors we can fit into the memory map.

Fixes: kata-containers#584

Signed-off-by: Penny Zheng <[email protected]>
Signed-off-by: Wei Chen <[email protected]>
Pennyzct added a commit to Pennyzct/runtime that referenced this issue Sep 4, 2018
on aarch64, we support different gic interrupt controllers.
The maximum number of vCPUs depends on the GIC version, or on how
many redistributors we can fit into the memory map.

Fixes: kata-containers#584

Signed-off-by: Penny Zheng <[email protected]>
Signed-off-by: Wei Chen <[email protected]>
egernst pushed a commit to egernst/runtime that referenced this issue Feb 9, 2021
gcc __attribute__ constructors cannot take arguments and cannot
access main function arguments on musl. Such functionality is glibc
specific and only works on x86 and x86_64. As a result, the pause
binary always quits on musl causing sandbox share pidns to malfunction.

Fix it by grabbing arguments from /proc/self/cmdline instead.

Fixes: kata-containers#584
Signed-off-by: Peng Tao <[email protected]>
egernst pushed a commit to egernst/runtime that referenced this issue Feb 9, 2021
gcc __attribute__ constructors cannot take arguments and cannot
access main function arguments on musl. Such functionality is glibc
specific and only works on x86 and x86_64. As a result, the pause
binary always quits on musl causing sandbox share pidns to malfunction.

Let's use env to indicate pause instead.

Fixes: kata-containers#584
Signed-off-by: Peng Tao <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant