This repository has been archived by the owner on May 12, 2021. It is now read-only.
client.go: HybridVSockDialer: Change Read EOT to recv peek #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifupan
approved these changes
Nov 28, 2019
teawater
force-pushed
the
fix_hvsock2
branch
from
418285f
to
1286084
Compare
Codecov Report
@@ Coverage Diff @@
## master #696 +/- ##
==========================================
- Coverage 60.57% 60.51% -0.07%
==========================================
Files 17 17
Lines 2534 2540 +6
==========================================
+ Hits 1535 1537 +2
- Misses 850 855 +5
+ Partials 149 148 -1 |
|
/test |
jodh-intel
approved these changes
Nov 28, 2019
protocols/client/client.go
Outdated
| // Just close the connection, gRPC will dial again | ||
| // without errors | ||
| conn.Close() | ||
| // Receive the package from the connection without remove this |
There was a problem hiding this comment.
Nit: s/package/packet/.
Just an idea but you could simplify this comment to something like:
Receive the packet from the connection without removing it from the receive queue (MSG_PEEK), ensuring the connection is usable.
There was a problem hiding this comment.
@jodh-intel Thanks! Pushed a new version according to your comments.
Rust agent(grpc-rs) cannot work with firecacker because the first package will be dropped or truncated by HybridVSockDialer read EOT code. This issue was reported in kata-containers/kata-containers#79 Golang agent(grpc-golang) is also affected by this issue. But it is first package is 9 bytes FRAME_SETTINGS. Drop it will not affect subsequent communications. This commit change to use recv peek that will do same check with read EOT but not drop any package. Fixes: kata-containers#695 Signed-off-by: Hui Zhu <[email protected]>
teawater
force-pushed
the
fix_hvsock2
branch
from
1286084
to
f8e4ce8
Compare
|
/test |
|
Thanks again @teawater. Ping @kata-containers/agent. |
devimc
approved these changes
Nov 28, 2019
|
restarting firecracker CI |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust agent(grpc-rs) cannot work with firecacker because the first package
will be dropped or truncated by HybridVSockDialer read EOT code.
This issue was reported in
kata-containers/kata-containers#79
Golang agent(grpc-golang) is also affected by this issue. But it is first
package is 9 bytes FRAME_SETTINGS. Drop it will not affect subsequent
communications.
This commit change to use recv peek that will do same check with read
EOT but not drop any package.
Fixes: #695
Signed-off-by: Hui Zhu [email protected]