Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Rust agent(grpc-rs) cannot work with firecacker hybrid vsock #695

Closed
teawater opened this issue Nov 28, 2019 · 0 comments · Fixed by #696
Closed

Rust agent(grpc-rs) cannot work with firecacker hybrid vsock #695

teawater opened this issue Nov 28, 2019 · 0 comments · Fixed by #696
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@teawater
Copy link
Member

kata-containers/kata-containers#79
@teawater teawater added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Nov 28, 2019
teawater added a commit to teawater/agent that referenced this issue Nov 28, 2019
@teawater
client.go: HybridVSockDialer: Change Read EOT to recv peek
418285f 
Rust agent(grpc-rs) cannot work with firecacker because the first package
will be dropped or truncated by HybridVSockDialer read EOT code.
This issue was reported in
kata-containers/kata-containers#79

Golang agent(grpc-golang) is also affected by this issue.  But it is first
package is 9 bytes FRAME_SETTINGS.  Drop it will not affect subsequent
communications.

This commit change to use recv peek that will do same check with read
EOT but not drop any package.

Fixes: kata-containers#695

Signed-off-by: Hui Zhu <[email protected]>
@teawater teawater mentioned this issue Nov 28, 2019
Merged
teawater added a commit to teawater/agent that referenced this issue Nov 28, 2019
@teawater
client.go: HybridVSockDialer: Change Read EOT to recv peek
1286084 
Rust agent(grpc-rs) cannot work with firecacker because the first package
will be dropped or truncated by HybridVSockDialer read EOT code.
This issue was reported in
kata-containers/kata-containers#79

Golang agent(grpc-golang) is also affected by this issue.  But it is first
package is 9 bytes FRAME_SETTINGS.  Drop it will not affect subsequent
communications.

This commit change to use recv peek that will do same check with read
EOT but not drop any package.

Fixes: kata-containers#695

Signed-off-by: Hui Zhu <[email protected]>
teawater added a commit to teawater/agent that referenced this issue Nov 28, 2019
@teawater
client.go: HybridVSockDialer: Change Read EOT to recv peek
f8e4ce8 
Rust agent(grpc-rs) cannot work with firecacker because the first package
will be dropped or truncated by HybridVSockDialer read EOT code.
This issue was reported in
kata-containers/kata-containers#79

Golang agent(grpc-golang) is also affected by this issue.  But it is first
package is 9 bytes FRAME_SETTINGS.  Drop it will not affect subsequent
communications.

This commit change to use recv peek that will do same check with read
EOT but not drop any package.

Fixes: kata-containers#695

Signed-off-by: Hui Zhu <[email protected]>
@teawater teawater mentioned this issue Nov 29, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

client.go: HybridVSockDialer: Change Read EOT to recv peek teawater/agent
1 participant
@teawater