mount: Virtio-blk container rootfs mount for ACRN hypervisor

[vijaydhanraj]

For block devices added by acrn, virtpath is directly udpated
in storage.source and so no scanning of PCIAddr is required.
This is because, the virtio-blk device is not hot-plugged but
added during VM launch and updated later with container rootfs
using block rescan feature.

Fixes: #573

Signed-off-by: Vijay Dhanraj [email protected]

[vijaydhanraj]

Related to: kata-containers/runtime#1779

[amshinde]

@vijaydhanraj Seeing this error:

mount.go:275: File is not `gofmt`-ed with `-s` (gofmt)
        // If hot-plugged, get the device node path based on the PCI address else
        // use the virt path provided in Storage Source
        if strings.Contains(storage.Source, "/dev") {
                // Make sure the virt path is valid
                _, err := os.Stat(storage.Source)
                if err != nil {
                        return "", err
                }
        } else {
                devPath, err := getPCIDeviceName(s, storage.Source)
                if err != nil {
                        return "", err
                }

Can you gofmt the mount.go file?

[vijaydhanraj]

@vijaydhanraj Seeing this error:

mount.go:275: File is not `gofmt`-ed with `-s` (gofmt)
        // If hot-plugged, get the device node path based on the PCI address else
        // use the virt path provided in Storage Source
        if strings.Contains(storage.Source, "/dev") {
                // Make sure the virt path is valid
                _, err := os.Stat(storage.Source)
                if err != nil {
                        return "", err
                }
        } else {
                devPath, err := getPCIDeviceName(s, storage.Source)
                if err != nil {
                        return "", err
                }

Can you gofmt the mount.go file?

Sure will do. Thanks!

[codecov]

Codecov Report

Merging #574 into master will increase coverage by 0.22%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master     #574      +/-   ##
==========================================
+ Coverage   50.39%   50.62%   +0.22%     
==========================================
  Files          17       17              
  Lines        2385     2392       +7     
==========================================
+ Hits         1202     1211       +9     
  Misses       1026     1026              
+ Partials      157      155       -2

[amshinde]

/test

[jodh-intel]

Please can you add some unit tests for this code? This is a very weak match (not anchored) so would match things like /home/developer/foo.txt. Can you add anchoring reliably to guarantee you only match on actual devices?

[vijaydhanraj]

Using HasPrefix() now instead of Contains. Added a few negative test cases to check the flow.

[jodh-intel]

If you are matching devices, can you use os.Stat.Mode() and os.ModeDevice to check you really got one?

[vijaydhanraj]

done

[bergwolf]

/test