Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

mount: virtioblk container rootfs mount for ACRN hypervisor #573

Closed
vijaydhanraj opened this issue Jun 6, 2019 · 0 comments · Fixed by #574
Closed

mount: virtioblk container rootfs mount for ACRN hypervisor #573

vijaydhanraj opened this issue Jun 6, 2019 · 0 comments · Fixed by #574
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.

Comments

@vijaydhanraj
Copy link
Contributor

For block devices added by acrn, virtpath is directly updated in storage.source and so no scanning of PCIAddr is required. This is because the virtio-blk device is not hot-plugged but added during VM launch and updated later with container rootfs using block rescan feature.
@vijaydhanraj vijaydhanraj added enhancement Improvement to an existing feature needs-review Needs to be assessed by the team. labels Jun 6, 2019
vijaydhanraj added a commit to vijaydhanraj/agent that referenced this issue Jun 7, 2019
@vijaydhanraj
mount: Virtio-blk container rootfs mount for ACRN hypervisor
178e4ac 
For block devices added by acrn, virtpath is directly udpated
in storage.source and so no scanning of PCIAddr is required.
This is because, the virtio-blk device is not hot-plugged but
added during VM launch and updated later with container rootfs
using block rescan feature.

Fixes: kata-containers#573

Signed-off-by: Vijay Dhanraj <[email protected]>
@vijaydhanraj vijaydhanraj mentioned this issue Jun 7, 2019
Merged
vijaydhanraj added a commit to vijaydhanraj/agent that referenced this issue Jun 7, 2019
@vijaydhanraj
mount: Virtio-blk container rootfs mount for ACRN hypervisor
119f976 
For block devices added by acrn, virtpath is directly udpated
in storage.source and so no scanning of PCIAddr is required.
This is because, the virtio-blk device is not hot-plugged but
added during VM launch and updated later with container rootfs
using block rescan feature.

v1->v2:
gofmt'd the mount file.

Fixes: kata-containers#573

Signed-off-by: Vijay Dhanraj <[email protected]>
vijaydhanraj added a commit to vijaydhanraj/agent that referenced this issue Jun 12, 2019
@vijaydhanraj
mount: Virtio-blk container rootfs mount for ACRN hypervisor
9b59925 
For block devices added by acrn, virtpath is directly udpated
in storage.source and so no scanning of PCIAddr is required.
This is because, the virtio-blk device is not hot-plugged but
added during VM launch and updated later with container rootfs
using block rescan feature.

v2->v3:
1. Addressed weak match for checking storage block device.
2. Added device check for storage block device.
3. Added negative unit tests for the new code.

v1->v2:
gofmt'd the mount file.

Fixes: kata-containers#573

Signed-off-by: Vijay Dhanraj <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mount: Virtio-blk container rootfs mount for ACRN hypervisor vijaydhanraj/agent
1 participant
@vijaydhanraj