Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add forType in binding status controller to inherit concurrency declared in global options #4340

Merged

Conversation

lxtywypc
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #4339

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controllr-manager`: concurrency of `binding-status controller` inherit from the concurrency of `binding` declared in global options

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 30, 2023
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 30, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (a37961c) 53.89% compared to head (eb429a5) 53.88%.

Files Patch % Lines
pkg/controllers/status/common.go 0.00% 4 Missing ⚠️
pkg/controllers/status/crb_status_controller.go 0.00% 1 Missing ⚠️
pkg/controllers/status/rb_status_controller.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.7    #4340      +/-   ##
===============================================
- Coverage        53.89%   53.88%   -0.02%     
===============================================
  Files              231      231              
  Lines            22951    22957       +6     
===============================================
  Hits             12370    12370              
- Misses            9913     9919       +6     
  Partials           668      668              
Flag Coverage Δ
unittests 53.88% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member

Ask @RainbowMango to help rerun the CI.
/cc @RainbowMango

@XiShanYongYe-Chang
Copy link
Member

/assign

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

pkg/controllers/status/common.go Show resolved Hide resolved
@XiShanYongYe-Chang
Copy link
Member

/lgtm
/cc @RainbowMango

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023
@XiShanYongYe-Chang
Copy link
Member

/cc @RainbowMango
Ask @RainbowMango to help review it.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Seems the #4338 fixed the issue, this PR more like a cherry-pick on release-1.7.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2023
@karmada-bot karmada-bot merged commit 9e04c2e into karmada-io:release-1.7 Dec 21, 2023
12 checks passed
karmada-bot added a commit that referenced this pull request Dec 21, 2023
…k-of-#4340-upstream-release-1.6

Automated cherry pick of #4340: add forType in binding status controller to inherit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants