-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add forType in binding status controller to inherit concurrency declared in global options #4340
add forType in binding status controller to inherit concurrency declared in global options #4340
Conversation
…red in global options Signed-off-by: lxtywypc <[email protected]>
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release-1.7 #4340 +/- ##
===============================================
- Coverage 53.89% 53.88% -0.02%
===============================================
Files 231 231
Lines 22951 22957 +6
===============================================
Hits 12370 12370
- Misses 9913 9919 +6
Partials 668 668
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ask @RainbowMango to help rerun the CI. |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm |
/cc @RainbowMango |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Seems the #4338 fixed the issue, this PR more like a cherry-pick on release-1.7.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…k-of-#4340-upstream-release-1.6 Automated cherry pick of #4340: add forType in binding status controller to inherit
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4339
Special notes for your reviewer:
Does this PR introduce a user-facing change?: