-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #4340: add forType in binding status controller to inherit #4461
Automated cherry pick of #4340: add forType in binding status controller to inherit #4461
Conversation
1bbb301
to
7a1bd28
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release-1.6 #4461 +/- ##
===============================================
- Coverage 54.34% 54.33% -0.01%
===============================================
Files 223 223
Lines 21305 21311 +6
===============================================
+ Hits 11578 11580 +2
- Misses 9102 9106 +4
Partials 625 625
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Please look at the failing lint check. |
…red in global options Signed-off-by: changzhen <[email protected]>
7a1bd28
to
756b3b1
Compare
It's ready now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick of #4340 on release-1.6.
#4340: add forType in binding status controller to inherit
For details on the cherry pick process, see the cherry pick requests page.