Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #4340: add forType in binding status controller to inherit #4461

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Dec 21, 2023

Cherry pick of #4340 on release-1.6.
#4340: add forType in binding status controller to inherit
For details on the cherry pick process, see the cherry pick requests page.

`karmada-controllr-manager`: concurrency of `binding-status controller` inherit from the concurrency of `binding` declared in global options

@karmada-bot karmada-bot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Dec 21, 2023
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 21, 2023
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the automated-cherry-pick-of-#4340-upstream-release-1.6 branch from 1bbb301 to 7a1bd28 Compare December 21, 2023 07:17
@karmada-bot karmada-bot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Dec 21, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (84d48ab) 54.34% compared to head (7a1bd28) 54.33%.
Report is 1 commits behind head on release-1.6.

Files Patch % Lines
pkg/controllers/status/common.go 0.00% 4 Missing ⚠️
pkg/controllers/status/crb_status_controller.go 0.00% 1 Missing ⚠️
pkg/controllers/status/rb_status_controller.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.6    #4461      +/-   ##
===============================================
- Coverage        54.34%   54.33%   -0.01%     
===============================================
  Files              223      223              
  Lines            21305    21311       +6     
===============================================
+ Hits             11578    11580       +2     
- Misses            9102     9106       +4     
  Partials           625      625              
Flag Coverage Δ
unittests 54.33% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango
Copy link
Member

Please look at the failing lint check.

@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the automated-cherry-pick-of-#4340-upstream-release-1.6 branch from 7a1bd28 to 756b3b1 Compare December 21, 2023 11:46
@XiShanYongYe-Chang
Copy link
Member Author

Please look at the failing lint check.

It's ready now.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2023
@karmada-bot karmada-bot merged commit 4a69018 into karmada-io:release-1.6 Dec 21, 2023
12 checks passed
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the automated-cherry-pick-of-#4340-upstream-release-1.6 branch February 26, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants