feat: agent add metrics-bind-address flag #1953
Conversation
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/XS
Can you give a more detailed reason why we need it? |
I have other application running and listen on port 8080, agent installed on this machine have error |
| @@ -112,4 +117,5 @@ func (o *Options) AddFlags(fs *pflag.FlagSet, allControllers []string) { | |||
| fs.IntVar(&o.ConcurrentClusterSyncs, "concurrent-cluster-syncs", 5, "The number of Clusters that are allowed to sync concurrently.") | |||
| fs.IntVar(&o.ConcurrentWorkSyncs, "concurrent-work-syncs", 5, "The number of Works that are allowed to sync concurrently.") | |||
| o.RateLimiterOpts.AddFlags(fs) | |||
| fs.StringVar(&o.MetricsBindAddress, "metrics-bind-address", ":8080", "The TCP address that the controller should bind to for serving prometheus metrics(e.g. 127.0.0.1:8088, :8088)") | |||
There was a problem hiding this comment.
Karmada-controller-manager already has MetricsBindAddress. It's ok to add it in agent. How about move the flag above o.RateLimiterOpts.AddFlags(fs)?
There was a problem hiding this comment.
How about move the flag above o.RateLimiterOpts.AddFlags(fs)?
review again please
Signed-off-by: charlesQQ <[email protected]>
CharlesQQ
force-pushed
the
karmada-agent-metrics
branch
from
feb60b6 to
fe40364
Compare
|
/approve We forgot to add this flag at #1346. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
|
/lgtm @Poor12 The |
Signed-off-by: charlesQQ [email protected]
What type of PR is this?
/kind feature
What this PR does / why we need it:
avoid port conflict
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: