Introduce --metrics-bind-address and --health-probe-bind-address flags to karmada-webhook
#1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
kind/feature
karmada-bot
added
the
size/S
mrlihanbo
force-pushed
the
webhook-health
branch
from
9ad5cd9 to
ecc4dfa
Compare
karmada-bot
added
release-note
pigletfly
suggested changes
Feb 9, 2022
mrlihanbo
force-pushed
the
webhook-health
branch
from
ecc4dfa to
e647037
Compare
Signed-off-by: lihanbo <[email protected]>
Signed-off-by: RainbowMango <[email protected]>
RainbowMango
force-pushed
the
webhook-health
branch
from
e647037 to
9af89e6
Compare
|
/retitle Introduce I added a commit to update the usage of /approve leave LGTM to @pigletfly to confirm. |
karmada-bot
changed the title
--metrics-bind-address and --health-probe-bind-address flags to karmada-webhook
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
|
/assign @pigletfly |
|
/cc @pigletfly |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lihanbo [email protected]
What type of PR is this?
/kind feature
What this PR does / why we need it:
Some users want to config the MetricsBindAddress and HealthProbeBindAddress for karmada-webhook.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
It can be set to "0" to disable the metrics serving and health probe serving.
Does this PR introduce a user-facing change?: