Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump base cluster from v1.21.1 to v1.22.0 #1256

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

wlp1153468871
Copy link
Member

Signed-off-by: 卫璐萍 [email protected]

What type of PR is this?

/kind cleanup

Which issue(s) this PR fixes:
Fixes #1252

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 14, 2022
@karmada-bot
Copy link
Collaborator

Welcome @wlp1153468871! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 14, 2022
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wlp1153468871 Thanks for help doing this. You might have to config your git configuration.

I see your commit is:

Author: 卫璐萍 <[email protected]>
Date:   Fri Jan 14 09:44:47 2022 +0800

    Bump base cluster from v1.21.1 to v1.22.0
    
    Signed-off-by: 卫璐萍 <[email protected]>
  1. Your email [email protected] can't be identified by GitHub, which means your contribution can't be counted.
  2. We usually don't use Chinese names in commits.

@RainbowMango
Copy link
Member

You can do that by following commands.

$ git config --global user.name <your name>
$ git config --global user.email <your email>
$ git commit --amend --reset-author
$ git commit -s --amend // Update signed-off-by 

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks again! And this PR will be merged once the testing is done.
Welcome!

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2022
@RainbowMango
Copy link
Member

/hold

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2022
@RainbowMango
Copy link
Member

@wlp1153468871

Author: 卫璐萍 <[email protected]>
Date:   Fri Jan 14 09:44:47 2022 +0800

    Bump base cluster from v1.21.1 to v1.22.0
    
    Signed-off-by: wlp1153468871 <[email protected]>

Signed off info is correct now.
You might have to update the author and email as well.

@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2022
@RainbowMango
Copy link
Member

/lgtm
/hold cancel

@karmada-bot karmada-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 14, 2022
@karmada-bot karmada-bot merged commit 9d16360 into karmada-io:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[testing] Bump base cluster from v1.21.1 to v1.22.0
3 participants