-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump base cluster from v1.21.1 to v1.22.0 #1256
Bump base cluster from v1.21.1 to v1.22.0 #1256
Conversation
Welcome @wlp1153468871! It looks like this is your first PR to karmada-io/karmada 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wlp1153468871 Thanks for help doing this. You might have to config your git configuration.
I see your commit is:
Author: 卫璐萍 <[email protected]>
Date: Fri Jan 14 09:44:47 2022 +0800
Bump base cluster from v1.21.1 to v1.22.0
Signed-off-by: 卫璐萍 <[email protected]>
- Your email
[email protected]
can't be identified by GitHub, which means your contribution can't be counted. - We usually don't use Chinese names in commits.
You can do that by following commands.
|
9fb8d09
to
8077aca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks again! And this PR will be merged once the testing is done.
Welcome!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Signed off info is correct now. |
Signed-off-by: wlp1153468871 <[email protected]>
8077aca
to
12da130
Compare
/lgtm |
Signed-off-by: 卫璐萍 [email protected]
What type of PR is this?
/kind cleanup
Which issue(s) this PR fixes:
Fixes #1252
Does this PR introduce a user-facing change?: