fix: work around broken console methods #3085
Conversation
context/karma.js
Outdated
| return Function.prototype.apply.call(orig, localConsole, arguments) | ||
| } catch (error) { | ||
| // Sometimes native console methods are broken, but this shouldn't break tests. | ||
| // It is especially undesirable in environments like Sauce Labs with limited access to the browser settings. |
There was a problem hiding this comment.
Please remove the three lines of comment. The info in the commit message is adequate.
context/karma.js
Outdated
| // Sometimes native console methods are broken, but this shouldn't break tests. | ||
| // It is especially undesirable in environments like Sauce Labs with limited access to the browser settings. | ||
| // See https://stackoverflow.com/questions/46913856/value-is-not-a-sequence-safari-exception | ||
| self.log('warn', ['Native method console.' + method + ' is broken:', error]) |
There was a problem hiding this comment.
Please use string literal but without attributing the throw to a cause:
`Console method ${method} threw: ${error}`This issue can also arise if users overwrite console: it may not be a native method problem.
There was a problem hiding this comment.
Turns out we can't use ES2015 there. If we do, it doesn't work in Phantom and other old browsers.
|
@johnjbarton Not sure what happened to Travis, but looks unrelated to this PR. Please have a look, |
|
The error is |
|
Let's see if #3087 helps here. |
|
Please sync to master and rebase. I think the longer timeout will allow CI to pass. |
|
closing and opening to trigger travis |
thorn0
changed the title
Sometimes console methods are broken, but this shouldn't break tests. See angular/angular.js#16644 (comment)
|
@johnjbarton Travis is green finally. It was failing because I tried to use ES2015 (template literals) in |
Sometimes native console methods are broken, but this shouldn't break tests.
It is especially undesirable in environments like Sauce Labs with limited access to the browser settings.
See angular/angular.js#16644 (comment)