This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(Angular): add workaround for Safari / Webdriver error #16645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not wait until karma-runner/karma#3085 gets merged and released? |
|
Oh cool I didn't know about this PR. I thought this must be fixed inside Webdriver or by Saucelabs |
|
We will remove this workaround once this is fixed upstream |
|
Karma 3.1.0 has been released with a fix for this. |
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
Oct 25, 2018
This allows us to remove the workaround added in angular#16645
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
Oct 25, 2018
This allows us to remove the workaround added in angular#16645
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
Nov 2, 2018
This allows us to remove the workaround added in angular#16645
Narretz
added a commit
that referenced
this pull request
Nov 23, 2018
This allows us to remove the workaround added in #16645
Narretz
added a commit
that referenced
this pull request
Nov 26, 2018
This allows us to remove the workaround added in #16645
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: