Add possibility to stop a karma server #1854

budde377 · 2016-01-31T19:59:15Z

This is a fix for issue #136. This:

Add detached mode using the karma start --detached command.
Add middleware for stopping a server (detached or not).
Described the detached option.

Any pointers on testing this or describing the new command (karma stop)?

dignifiedquire · 2016-02-04T20:17:49Z

Thanks for this. I would really like to see an e2e test making sure this works as expected.

dignifiedquire · 2016-02-04T20:19:27Z

Any pointers on testing this or describing the new command (karma stop)?

Take a look at the support files for the e2e tests, they are relatively straightforward javascript functions https://github.com/karma-runner/karma/blob/master/test/e2e/steps/core_steps.js#L43
We would need to add one for stop to test this. For docs on cucumberjs see here: https://github.com/cucumber/cucumber-js

budde377 · 2016-02-05T10:20:33Z

Cheers, I'll have a look at this ASAP.

On Thu, Feb 4, 2016 at 9:24 PM Friedel Ziegelmayer [email protected]
wrote:

Any pointers on testing this or describing the new command (karma stop)?

Take a look at the support files for the e2e tests, they are relatively
straightforward javascript functions
https://github.com/karma-runner/karma/blob/master/test/e2e/steps/core_steps.js#L43
We would need to add one for stop to test this. For docs on cucumberjs
see here: https://github.com/cucumber/cucumber-js

—
Reply to this email directly or view it on GitHub
#1854 (comment).

budde377 · 2016-02-08T16:35:53Z

Now testing:

Stopping a server that isn't running
Stopping a server that is running
- Succesfull termination
- Informative error message

dignifiedquire · 2016-02-10T20:43:54Z

test/e2e/stop.feature

@@ -0,0 +1,42 @@
+Feature: Stop karma
+  TODO write this


missing todo ;)

dignifiedquire · 2016-02-10T20:47:38Z

This is pretty sweet, one thing that would be nice is to have the stopper be also available on the public api (http://karma-runner.github.io/0.13/dev/public-api.html) and have some docs on how to use it. This could be used then in things like task runners to make it easier to spawn long running processes.

budde377 · 2016-02-10T20:57:28Z

Yeah, I can see that! I'll add it.

On Wed, Feb 10, 2016 at 9:47 PM Friedel Ziegelmayer <
[email protected]> wrote:

This is pretty sweet, one thing that would be nice is to have the stopper
be also available on the public api (
http://karma-runner.github.io/0.13/dev/public-api.html) and have some
docs on how to use it. This could be used then in things like task runners
to make it easier to spawn long running processes.

—
Reply to this email directly or view it on GitHub
#1854 (comment).

budde377 · 2016-02-11T18:40:15Z

@dignifiedquire Here you go.

dignifiedquire · 2016-02-11T18:44:57Z

docs/dev/04-public-api.md

+
+### **stopper.stop(options, [callback=process.exit])**
+
+This function will signal a running server to stop.  Equivalent of `karma stop`.  


Will this work if detached=false?

The detached setting is currently only working when running the server from CLI, since it's basically just calling itself in a new detached process.

So yes and no: The stop command will stop the server regardless of the detached setting and the server will not run detached when starting it programically. If this is a priority I'll certainly look into it.

We are doing sth very similar here: https://github.com/karma-runner/grunt-karma/blob/master/tasks/grunt-karma.js#L114-L134 so it would be nice if we could replace that with this new option, rather than duplication that effort

Cool, I'll look into it during the weekend.

budde377 · 2016-02-13T16:16:23Z

@dignifiedquire I have added the detached feature. In order to do so, I had to write the configuration as a file, hence the tmp dependency.

dignifiedquire · 2016-02-19T20:56:50Z

@budde377 I think the e2e tests are not passing anymore :(

Add detached mode using the `karma start --detached` command. Add middleware for stopping a server (detached or not). Described the detached option.

Add the `stopper` as a command to the public API allowing for enabling users to programically terminate a running server.

When setting `detached=true` in config, the server will start detached.

Default config to empty Object if undefined.

Add a setup-function for setting up the log-level and colors from config.

budde377 · 2016-02-21T10:02:13Z

@dignifiedquire, This should do the trick.

budde377 · 2016-02-21T10:05:58Z

A bit too fast there, I'll take a look at the failing node 0.10.

Change the timing on tests, allowing Node 0.10 to catch-up.

budde377 · 2016-02-21T20:15:12Z

@dignifiedquire Done

dignifiedquire · 2016-02-22T09:54:30Z

Thanks @budde377 merging this. Let's hope this time around things go smoother :)

Add possibility to stop a karma server

dignifiedquire mentioned this pull request Feb 1, 2016

Karma dignifiedquire/public-todos#2

Closed

3 tasks

dignifiedquire added the needs: review label Feb 4, 2016

dignifiedquire added needs: feedback-from-author and removed needs: review labels Feb 4, 2016

budde377 force-pushed the feature-stop-karma-server branch from 9342a53 to 4c8f6e0 Compare February 8, 2016 16:31

budde377 force-pushed the feature-stop-karma-server branch from 4c8f6e0 to db79170 Compare February 8, 2016 19:04

dignifiedquire reviewed Feb 10, 2016
View reviewed changes

test/e2e/stop.feature

@@ -0,0 +1,42 @@

Feature: Stop karma

TODO write this

Copy link

Member

dignifiedquire Feb 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing todo ;)

budde377 force-pushed the feature-stop-karma-server branch from db79170 to 1fe10fc Compare February 11, 2016 18:39

dignifiedquire removed the needs: feedback-from-author label Feb 11, 2016

dignifiedquire reviewed Feb 11, 2016
View reviewed changes

dignifiedquire added the needs: review label Feb 13, 2016

dignifiedquire self-assigned this Feb 13, 2016

budde377 force-pushed the feature-stop-karma-server branch from 8b5f5e5 to 3784109 Compare February 13, 2016 17:23

dignifiedquire added needs: feedback-from-author and removed needs: review labels Feb 19, 2016

dignifiedquire added this to the v1.0 milestone Feb 19, 2016

budde377 added 5 commits February 21, 2016 10:44

feat: Add possibility to stop a karma server

66ae80b

Add detached mode using the `karma start --detached` command. Add middleware for stopping a server (detached or not). Described the detached option.

feat: Add stopper to the public API

3d4fa00

Add the `stopper` as a command to the public API allowing for enabling users to programically terminate a running server.

feat(stopper): Enable programically detached server

f10fd81

When setting `detached=true` in config, the server will start detached.

fix: Setting default value for config in runner and stopper

414db89

Default config to empty Object if undefined.

feat(logging): Add logging-setup function

d14bd62

Add a setup-function for setting up the log-level and colors from config.

budde377 force-pushed the feature-stop-karma-server branch from 3784109 to d14bd62 Compare February 21, 2016 09:57

fix: Change timing on test

0cb6204

Change the timing on tests, allowing Node 0.10 to catch-up.

dignifiedquire added a commit that referenced this pull request Feb 22, 2016

Merge pull request #1854 from budde377/feature-stop-karma-server

6fe5a77

Add possibility to stop a karma server

dignifiedquire merged commit 6fe5a77 into karma-runner:master Feb 22, 2016

dignifiedquire removed the needs: feedback-from-author label Feb 22, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add possibility to stop a karma server #1854

Add possibility to stop a karma server #1854

budde377 commented Jan 31, 2016

dignifiedquire commented Feb 4, 2016

dignifiedquire commented Feb 4, 2016

budde377 commented Feb 5, 2016

budde377 commented Feb 8, 2016

dignifiedquire Feb 10, 2016

dignifiedquire commented Feb 10, 2016

budde377 commented Feb 10, 2016

budde377 commented Feb 11, 2016

dignifiedquire Feb 11, 2016

budde377 Feb 11, 2016

dignifiedquire Feb 11, 2016

budde377 Feb 11, 2016

budde377 commented Feb 13, 2016

dignifiedquire commented Feb 19, 2016

budde377 commented Feb 21, 2016

budde377 commented Feb 21, 2016

budde377 commented Feb 21, 2016

dignifiedquire commented Feb 22, 2016


		### stopper.stop(options, [callback=process.exit])

		This function will signal a running server to stop. Equivalent of `karma stop`.

Add possibility to stop a karma server #1854

Add possibility to stop a karma server #1854

Conversation

budde377 commented Jan 31, 2016

dignifiedquire commented Feb 4, 2016

dignifiedquire commented Feb 4, 2016

budde377 commented Feb 5, 2016

budde377 commented Feb 8, 2016

dignifiedquire Feb 10, 2016

Choose a reason for hiding this comment

dignifiedquire commented Feb 10, 2016

budde377 commented Feb 10, 2016

budde377 commented Feb 11, 2016

dignifiedquire Feb 11, 2016

Choose a reason for hiding this comment

budde377 Feb 11, 2016

Choose a reason for hiding this comment

dignifiedquire Feb 11, 2016

Choose a reason for hiding this comment

budde377 Feb 11, 2016

Choose a reason for hiding this comment

budde377 commented Feb 13, 2016

dignifiedquire commented Feb 19, 2016

budde377 commented Feb 21, 2016

budde377 commented Feb 21, 2016

budde377 commented Feb 21, 2016

dignifiedquire commented Feb 22, 2016