Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to stop a karma server #136

Closed
nidi3 opened this issue Oct 21, 2012 · 10 comments
Closed

Add possibility to stop a karma server #136

nidi3 opened this issue Oct 21, 2012 · 10 comments

Comments

@nidi3
Copy link

nidi3 commented Oct 21, 2012

When you start testacular with singleRun=false from within a script (Eg. build script) there is no way to stop it again (apart from killing the process manually).

Someting like

node testacular stop 9876

would be nice.

@vojtajina
Copy link
Contributor

testacular stop --runner-port 9876

That reminds me we should use the same port for runner as well as web server, then it would be testacular stop --port 9876

@dignifiedquire
Copy link
Member

  1. We should add a short option so it would be just testacular stop -p 9876
  2. When we are on that topic what about an option --detached for testacular start. This would allow for the process to run in the background and be stopped with this command.

@vojtajina
Copy link
Contributor

+1 for --detached, testacular stop sounds good as well

@nidi3
Copy link
Author

nidi3 commented Jun 9, 2013

Any news regarding this issue?

@vojtajina
Copy link
Contributor

Sorry, not a high priority now. I like the suggestion, but need to do other stuff first (eg. improve the communication protocol between karma server and karma run so that we can send other messages than just "run tests"; also refactor karma to only use single port for web server and the communication with other processes).

Send a pull request if you want it really badly ;-)

@jasiedu
Copy link

jasiedu commented Jul 9, 2013

It is not a high priority to sto a server that you started? Wow!

@vojtajina
Copy link
Contributor

@jasiedu Currently you can stop the server by pressing control+c or in --single-run mode it exits after executing all the tests.

I work on this project in my free time, if you want to help, that's awesome. Otherwise you fall into "trolling" group, which is ok, have fun ;-)

@budde377
Copy link
Member

@dignifiedquire We can close this, right?

@dignifiedquire
Copy link
Member

Yes we can thanks to you :)

@joeflack4
Copy link

joeflack4 commented Oct 2, 2018

@vojtajina
Still staying open for me

(datalab) joe:datalab joeflack4$ ./node_modules/karma/bin/karma start --single-run
02 10 2018 12:40:51.691:WARN [watcher]: Pattern "/Users/joeflack4/projects/datalab/test/fixtures/**/*" does not match any file.
ℹ 「wdm」: Hash: 1af0291e2b7daf4c1038
Version: webpack 3.10.0
Time: 61ms
ℹ 「wdm」: Compiled successfully.
02 10 2018 12:40:51.712:WARN [watcher]: Pattern "/Users/joeflack4/projects/datalab/test/fixtures/**/*" does not match any file.
ℹ 「wdm」: Compiling...
ℹ 「wdm」: wait until bundle finished: noop
ℹ 「wdm」: wait until bundle finished: noop
ℹ 「wdm」: wait until bundle finished: noop
ℹ 「wdm」: wait until bundle finished: noop
ℹ 「wdm」: Hash: 80d465b0bcc75b9fc8d3
Version: webpack 3.10.0
Time: 1324ms
                               Asset     Size  Chunks                    Chunk Names
      test/javascripts/chart.test.js  1.01 MB       0  [emitted]  [big]  test/javascripts/chart.test
    test/javascripts/network.test.js   445 kB       1  [emitted]  [big]  test/javascripts/network.test
  test/javascripts/url-parse.test.js   380 kB       2  [emitted]  [big]  test/javascripts/url-parse.test
test/javascripts/definitions.test.js   407 kB       3  [emitted]  [big]  test/javascripts/definitions.test
    test/javascripts/utility.test.js   408 kB       4  [emitted]  [big]  test/javascripts/utility.test
   [7] ./node_modules/babel-runtime/helpers/classCallCheck.js 208 bytes {0} {1} {2} {3} {4} [built]
  [24] ./source/javascripts/utility.js 5.58 kB {0} {1} {3} {4} [built]
  [78] ./test/javascripts/chart.test.js 6.47 kB {0} [built]
  [79] ./node_modules/jquery/dist/jquery.js 272 kB {0} [built]
  [80] ./node_modules/chai/index.js 40 bytes {0} {1} {2} {3} {4} [built]
 [103] ./node_modules/chai-spies/chai-spies.js 20.5 kB {0} {1} {3} {4} [built]
 [104] ./source/javascripts/chart.js 25 kB {0} [built]
 [162] ./source/javascripts/url-parse.js 2.05 kB {0} {2} [built]
 [170] ./source/javascripts/definitions.js 1.99 kB {0} {3} [built]
 [177] ./env.js 1.21 kB {0} {1} [built]
 [182] ./test/javascripts/definitions.test.js 1.36 kB {3} [built]
 [183] ./test/javascripts/network.test.js 1.29 kB {1} [built]
 [184] ./source/javascripts/network.js 5.41 kB {1} [built]
 [186] ./test/javascripts/url-parse.test.js 1.43 kB {2} [built]
 [187] ./test/javascripts/utility.test.js 4.67 kB {4} [built]
    + 173 hidden modules
ℹ 「wdm」: Compiled successfully.
02 10 2018 12:40:55.725:INFO [karma]: Karma v2.0.5 server started at http://0.0.0.0:9876/

It just hangs there after starting the server. This is whether or not I do karma start --single-run or set the singleRun: true directly in the config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants