Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Yarn lifecycle scripts #3566

Closed
handerss-spotfire opened this issue Oct 8, 2020 · 2 comments
Closed

Add support for Yarn lifecycle scripts #3566

handerss-spotfire opened this issue Oct 8, 2020 · 2 comments

Comments

@handerss-spotfire
Copy link

handerss-spotfire commented Oct 8, 2020

Using Yarn, karma cannot be added as a dependency resolved from GitHub due to package.json lacking a prepack script. When Yarn clones a package from github it runs npm install and npm pack, but since karma needs to be built before being packed the resulting package will not function.

See:
https://yarnpkg.com/advanced/lifecycle-scripts
#3530 (issue where this is a problem)

@devoto13
Copy link
Collaborator

devoto13 commented Oct 8, 2020

I believe this has been fixed by #3524. Are you trying to install the latest version from GitHub? Maybe your branch/version does not include this change?

UPD Yeah, I think it is a matter of rebasing #3531 to get it working. Or maybe you can submit a change requested in that PR, so we can merge it?

@handerss-spotfire
Copy link
Author

Did a quick test and it seems that #3524 does indeed fix this issue. I linked the wrong related issue, but #3530 is the reason for wanting to resolve from github (meant to link yarnpkg/berry#1515). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants