fix: patch karma to allow loading virtual packages

[snasirca]

Fixes #3530

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[snasirca]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[karmarunnerbot]

✅ Build karma 309 completed (commit f59ad662fb by @snasirca)

[AppVeyorBot]

✅ Build karma 2707 completed (commit f59ad662fb by @snasirca)

[karmarunnerbot]

✅ Build karma 308 completed (commit f59ad662fb by @snasirca)

[AppVeyorBot]

✅ Build karma 2708 completed (commit 693d0326da by @snasirca)

[karmarunnerbot]

✅ Build karma 310 completed (commit 693d0326da by @snasirca)

[karmarunnerbot]

✅ Build karma 309 completed (commit 693d0326da by @snasirca)

[snasirca]

What would be the best way to add regression coverage to this change?

[devoto13]

Thanks for fixing this!

A unit test with the problematic path similar to this should be enough.

[acls]

I just ran into this issue yesterday and would like to get this merged as soon a possible. I can write the unit test if needed.

[snasirca]

@acls @devoto13 I've added test coverage. Can you check if this is sufficient?

[karmarunnerbot]

✅ Build karma 313 completed (commit fa250594dc by @snasirca)

[AppVeyorBot]

✅ Build karma 2712 completed (commit fa250594dc by @snasirca)

[karmarunnerbot]

✅ Build karma 314 completed (commit fa250594dc by @snasirca)

[AppVeyorBot]

✅ Build karma 2713 completed (commit d95e16971b by @snasirca)

[karmarunnerbot]

✅ Build karma 315 completed (commit d95e16971b by @snasirca)

[karmarunnerbot]

✅ Build karma 314 completed (commit d95e16971b by @snasirca)

[snasirca]

@devoto13 can you review this?

[devoto13]

One comment for consistency, otherwise LGTM.

[devoto13]

I believe this should be changed to function as well to cover this branch. Please change it and add a corresponding test.

[crownofapollo]

@snasirca wondering about the status of this. I'm running into the same issue and found this potential fix.

[snasirca]

@snasirca wondering about the status of this. I'm running into the same issue and found this potential fix.

Sorry about the delay. This hasn't dropped off of radar. I'm on vacation and back by September 20. That'll be the earliest I can address the code review feedback.

[elpddev]

@snasirca Thank you for the hard work. I can confirm this is working for our project.

[johnjbarton]

This fix was subsequently merged in #3663