-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Package from git commit(karma) runs differently #1515
Comments
This comment has been minimized.
This comment has been minimized.
The reproduction case in your issue seems broken (ie it neither pass nor fail due to throwing an unmanaged exception):
Remember: any non-Jest exceptions will cause the test to be reported as broken. If you expect something to pass without throwing, you must wrap it into something like |
It's because karma isn't built when cloned from github since they don't have a |
Describe the bug
While waiting for the bug fix for my previous issue(#1508) to be merged and published in karma,
I tried adding the git commit that has the bug fix.
Now when running karma it fails with
Error: karma tried to access browserify, but it isn't declared in its dependencies
.When I've had similar errors in the past, adding them to my package.json would fix them.
Adding browserify, just causes others errors.
I've diffed the two karma .zip files in the yarn cache and they appear the same(other than the bug fix, obviously).
To Reproduce
I reused the repo from before to demonstrate the issue.
I also added a sherlock repro.
Reproduction
Environment if relevant (please complete the following information):
Issue running sherlock locally
This is more of a heads up, or maybe I was doing it wrong, but
I had to remove the following from .yarnrc.yml in order to run sherlock locally:
The text was updated successfully, but these errors were encountered: