Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream logs from kube-task #228

Merged
merged 3 commits into from
Aug 23, 2019
Merged

Stream logs from kube-task #228

merged 3 commits into from
Aug 23, 2019

Conversation

tdmanv
Copy link
Contributor

@tdmanv tdmanv commented Aug 23, 2019

Change Overview

  • Prints logs from kube task pod as soon as they're ready in the controller
  • Fixes some issues with WaitForPod* hanging

Issues

Pull request type

Please check the type of change your PR introduces:

  • Work in Progress
  • Refactoring (no functional changes, no api changes)
  • Trival/Minor
  • Bugfix
  • Feature
  • Documentation

Test Plan

[20:11:15]tom@tom-XPS-13-9360: (stream-log)~/src/kanister/pkg/function/ go test -v -check.v -check.f TestKubeTask
=== RUN   Test
INFO[0004] Pod: kanister-job-pstjh Container: container Out: ###Phase-output###: {"key":"version","value":"0.20.0"}
INFO[0015] Pod: kanister-job-w5bl2 Container: container Out: Tick: 1
INFO[0018] Pod: kanister-job-w5bl2 Container: container Out: Tick: 2
INFO[0018] Pod: kanister-job-w5bl2 Container: container Out: Tick: 3
PASS: kube_task_test.go:108: KubeTaskSuite.TestKubeTask 21.055s
OK: 1 passed
--- PASS: Test (21.12s)
PASS
ok      github.com/kanisterio/kanister/pkg/function     21.147s
  • Manual
  • Unit test
  • E2E

@tdmanv tdmanv requested review from pavannd1 and vkamra August 23, 2019 16:41
@tdmanv tdmanv merged commit 81a1693 into master Aug 23, 2019
@tdmanv tdmanv deleted the stream-log branch August 23, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants