Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous logs from spawned commands #231

Closed
tdmanv opened this issue Aug 23, 2019 · 2 comments
Closed

Continuous logs from spawned commands #231

tdmanv opened this issue Aug 23, 2019 · 2 comments

Comments

@tdmanv
Copy link
Contributor

tdmanv commented Aug 23, 2019

KubeTask and KubeExec currently only print logs after completion and for failures don't print anything. This makes it difficult to determine what happened during execution.

@tdmanv
Copy link
Contributor Author

tdmanv commented Aug 29, 2019

KubeTask and several other Functions use PodRunner:

type PodRunner struct {
.

I think it makes sense to consolidate log handling into this package.

We use PodRunner in the following Functions: https://github.com/kanisterio/kanister/search?l=Go&q=NewPodRunner&type=

Many of these Functions do the following:

  1. Wait for the pod to be ready
  2. Wait for the to complete
  3. Collect logs
  4. Parse output

This functionality can be improved and pushed into PodRunner.

@tdmanv tdmanv mentioned this issue Sep 6, 2019
9 tasks
@github-actions
Copy link
Contributor

This issue is marked as stale due to inactivity. Add a new comment to reactivate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants