🐛 Allow to power off DHW #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, trying to stop DHW when zone heating was also stopped failed. This comes from the impossibility to disable every feature (zone heating and DHW) at the same time: there is no OperatingMode corresponding to this state. We fix this in this patch by reusing the same logic than Zone climate entities: we can reach the target state by controlling another setting. In this case: the heatpump entire state. Need to disable DHW seems a rare use case to me (if one uses holidays mode) but at least we now have a consistent behavior. Fixes #30 Change-Id: I29ea322ee258e8f7f8d6656d8835a09675605141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, trying to stop DHW when zone heating was also stopped failed. This comes from the impossibility to disable every feature (zone heating and DHW) at the same time: there is no OperatingMode corresponding to this state.
We fix this in this patch by reusing the same logic than Zone climate entities: we can reach the target state by controlling another setting. In this case: the heatpump entire state.
Need to disable DHW seems a rare use case to me (if one uses holidays mode) but at least we now have a consistent behavior.
Fixes #30
Change-Id: I29ea322ee258e8f7f8d6656d8835a09675605141