Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHW value logic #30

Closed
geduxas opened this issue Oct 26, 2022 · 5 comments · Fixed by #33
Closed

DHW value logic #30

geduxas opened this issue Oct 26, 2022 · 5 comments · Fixed by #33

Comments

@geduxas
Copy link
Contributor

geduxas commented Oct 26, 2022

elif hvac_mode == HVACMode.OFF:
value = {
"0": "0",
"1": "1",
"2": "2",
"3": "3", # we don't have a way to completely shut down DHW, so it should be different than 3
"4": "1",
"5": "2",
"6": "2",
"7": "7",
"8": "7",
}[str(self._operating_mode)]
if value == 3:
_LOGGER.warn(
f"Impossible to set {hvac_mode} on this heatpump, we can't disable water heater when heating/cooling is already disabled"
)

For the 3 mode, I think would be best to switch off pump. If there is last option to heat DHW and you switch it off pump should turn off and that's it.
vice versa and with room thermostats, if DHW is not installed and you switch off heating for all zones, pump should turn off.

@PGnl
Copy link

PGnl commented Oct 26, 2022

I think I get what you mean, but I believe that is not in line with normal logic.
That is what the main switch on/off is for.
I would be careful changing the logic of the heat pump in a standard setup.
If this is really wanted, I would make “3” reliant on topic 100.

@kamaradclimber
Copy link
Owner

I am also not fond of switching off the pump altogether. Ill try to find a better way

@geduxas
Copy link
Contributor Author

geduxas commented Oct 26, 2022

I am also not fond of switching off the pump altogether. Ill try to find a better way

Why not? If heatpump left only DHW heating option, and user for some reason desides to switch it off.. so nothing left to heat. Then logical step would be to turn off pump.. it could be combined with that switch.

and same behavior heating/cooling in zones. For example you have Heat + DHW in 2 zone settings. If you turn off DHW, you left with Heating only, if you turn off 1 zone, you left with heating and second zone only.. after turning off last zone, nothing left to heat.. so pump should turn off..

@geduxas
Copy link
Contributor Author

geduxas commented Oct 26, 2022

I think I get what you mean, but I believe that is not in line with normal logic. That is what the main switch on/off is for. I would be careful changing the logic of the heat pump in a standard setup. If this is really wanted, I would make “3” reliant on topic 100.

Interesting what would be happened if you done this. Logically you can turn on /off DHW only while pump is in Off position.. and if you turn off pump while heating option left with DHW only.. and disable DHW.. what will happen after turning pump on? do anyone tried it before ? :)

@PGnl
Copy link

PGnl commented Oct 26, 2022

I would love to, but do not have DHW myself ;)
Not sure how that would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants