feat(FEC-13691): Application events analytics reporting to kava #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 5, 2024 10:39
JonathanTGold
requested review from
SivanA-Kaltura and
MosheMaorKaltura
and removed request for
SivanA-Kaltura and
MosheMaorKaltura
This was referenced Mar 5, 2024
Merged
added 2 commits
March 10, 2024 15:23
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This was referenced Mar 11, 2024
Merged
JonathanTGold
added a commit
to kaltura/playkit-js-bumper
that referenced
this pull request
Mar 11, 2024
…111) Add Events (used by kava analytics) Resolves: FEC-13743 Related PR: kaltura/playkit-js-kava#156 --------------------------------------------------------- Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
JonathanTGold
added a commit
to kaltura/playkit-js-transcript
that referenced
this pull request
Mar 11, 2024
…ics) (#180) Solves FEC-13719, FEC-13691 Related PR: kaltura/playkit-js-kava#156 --------- Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
JonathanTGold
added a commit
to kaltura/playkit-js-downloads
that referenced
this pull request
Mar 11, 2024
#43) ### Description of the Changes Adjusting Events (used by kava analytics) #### Solves FEC-13717 #### Related PR: kaltura/playkit-js-kava#156 --------- Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
SivanA-Kaltura
requested changes
Mar 12, 2024
| type: 'SHARE_CLICKED', | ||
| getEventModel: (): any => ({ | ||
| eventType: ApplicationEventType.BUTTON_CLICKED, | ||
| buttonName: 'Share_embed_open', |
There was a problem hiding this comment.
button names should be consts
There was a problem hiding this comment.
i don’t think so, it is not reused, anyway it is neither const nor let is is parm sent,
There was a problem hiding this comment.
Since there is no reuse for those names, and they exist only in one place, here, lets leave it as is
JonathanTGold
added a commit
to kaltura/playkit-js-dual-screen
that referenced
this pull request
Mar 12, 2024
Add Events (used by kava analytics) solves FEC-13736 Related PR: kaltura/playkit-js-kava#156
MosheMaorKaltura
approved these changes
Mar 12, 2024
JonathanTGold
added a commit
to kaltura/playkit-js-share
that referenced
this pull request
Mar 12, 2024
) ### Description of the Changes #### Solves FEC-13721 #### Related PR: kaltura/playkit-js-kava#156 --------- Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Add Application events analytics reporting to kava
Solves FEC-13691
Related PRs:
kaltura/playkit-js-share#40
kaltura/playkit-js-downloads#43
kaltura/playkit-js-dual-screen#131
kaltura/playkit-js-playlist#56
kaltura/playkit-js-navigation#352
kaltura/playkit-js-transcript#180
kaltura/playkit-js-bumper#111
kaltura/playkit-js-skip#22