[DualScreen Plugin]: Add Events (used by kava analytics) #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 3, 2024 14:17
|
|
||
| const HAS_DUAL_SCREEN_PLUGIN_OVERLAY = 'has-dual-screen-plugin-overlay'; | ||
| const PRESETS = ['Playback', 'Live', 'Ads']; | ||
| const IMAGE_PLAYER_ID = 'imagePlayer'; | ||
| const MAIN_PLAYER_ID = 'mainPlayer'; | ||
|
|
||
| export class DualScreen extends BasePlugin<DualScreenConfig> implements IEngineDecoratorProvider { | ||
| private _layout: Layout; | ||
| private layout!: Layout; |
There was a problem hiding this comment.
question = why do you need the "!", since layout can be null/
There was a problem hiding this comment.
it can’t be null, it is assigned on the constructor, so it is never = null
semarche-kaltura
approved these changes
Mar 12, 2024
JonathanTGold
added a commit
to kaltura/playkit-js-kava
that referenced
this pull request
Mar 12, 2024
Description of the Changes Add Application events analytics reporting to kava Solves FEC-13691 Related PRs: kaltura/playkit-js-share#40 kaltura/playkit-js-downloads#43 kaltura/playkit-js-dual-screen#131 kaltura/playkit-js-playlist#56 kaltura/playkit-js-navigation#352 kaltura/playkit-js-transcript#180 kaltura/playkit-js-bumper#111 kaltura/playkit-js-skip#22 --------- Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Events (used by kava analytics)
solves FEC-13736
Related PR:
kaltura/playkit-js-kava#156