-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] #29 Swagger 코드 스타일과 패키지 네이밍 컨벤션을 맞춰 보아요 #30
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
42e1923
[refactor] API 명세 인터페이스에 작성하고 구현하기
5dbf213
[refactor] 패키지 명 컨벤션에 맞게 변경
049c471
[refactor] 메서드 이름 컨벤션에 맞게 변경
a66dc3c
[chore] 사용하지 않는 import, 지역변수 삭제
16d9cb6
[refactor] static import 사용
ec7114b
[chore] 사용하지 않는 import 문 제거
f5862b1
[feat] 코드 최신화
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
src/main/java/team7/inplace/video/presentation/VideoControllerApiSpec.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
package team7.inplace.video.presentation; | ||
|
||
import io.swagger.v3.oas.annotations.Operation; | ||
import jakarta.servlet.http.HttpServletRequest; | ||
import org.springframework.http.ResponseEntity; | ||
import org.springframework.web.bind.annotation.ModelAttribute; | ||
import org.springframework.web.bind.annotation.RequestParam; | ||
import team7.inplace.video.presentation.dto.VideoResponse; | ||
import team7.inplace.video.presentation.dto.VideoSearchParams; | ||
|
||
import java.util.List; | ||
|
||
|
||
public interface VideoControllerApiSpec { | ||
@Operation( | ||
summary = "내 인플루언서가 방문한 or 내 주변 그곳 ", | ||
description = "토큰의 유무에 따라 다른 동작을 수행합니다." | ||
) | ||
public ResponseEntity<List<VideoResponse>> readVideos( | ||
HttpServletRequest request, | ||
@RequestParam(name = "influencer", required = false) List<String> influencers, | ||
@ModelAttribute VideoSearchParams searchParams, | ||
@RequestParam(defaultValue = "0", required = false) int page, | ||
@RequestParam(defaultValue = "10", required = false) int size | ||
Comment on lines
+20
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이거 잘 되나요??? 여기서 선언했을 때 잘 되는지 확인한번만 하고 알려주시면 감사하겠습니다. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 아직 데이터가 들어간게 없어서 로직은 잘 모르겠는데, 포스트맨으로 API 요청했을때는 오류 안나고 잘되었습니다 |
||
); | ||
|
||
@Operation(summary = "새로 등록된 그 곳", description = "id를 기준으로 내림차순 정렬한 Video 정보를 조회합니다.") | ||
public ResponseEntity<List<VideoResponse>> readByNew(); | ||
|
||
@Operation(summary = "쿨한 그 곳", description = "조회수를 기준으로 내림차순 정렬한 Video 정보를 조회합니다.") | ||
public ResponseEntity<List<VideoResponse>> readByCool(); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사소하지만 코드 컨벤션에 어긋나요!