[Refactor] #29 Swagger 코드 스타일과 패키지 네이밍 컨벤션을 맞춰 보아요 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2024 20:14
Controller를 구현체로 Interface를 만들어 명세를 작성하는 스타일 채택
BaeJunH0
changed the title
sanghee0820
reviewed
Oct 3, 2024
Comment on lines
+20
to
+24
| HttpServletRequest request, | ||
| @RequestParam(name = "influencer", required = false) List<String> influencers, | ||
| @ModelAttribute VideoSearchParams searchParams, | ||
| @RequestParam(defaultValue = "0", required = false) int page, | ||
| @RequestParam(defaultValue = "10", required = false) int size |
There was a problem hiding this comment.
이거 잘 되나요??? 여기서 선언했을 때 잘 되는지 확인한번만 하고 알려주시면 감사하겠습니다.
There was a problem hiding this comment.
아직 데이터가 들어간게 없어서 로직은 잘 모르겠는데, 포스트맨으로 API 요청했을때는 오류 안나고 잘되었습니다
sanghee0820
approved these changes
Oct 3, 2024
added 3 commits
October 4, 2024 13:47
클래스에 정의된 상수 사용을 static import 방식으로 변경
suhyeon7497
approved these changes
Oct 4, 2024
| @@ -19,15 +18,11 @@ | |||
| @RestController | |||
| @RequiredArgsConstructor | |||
| @RequestMapping("/videos") | |||
| public class VideoController { | |||
| public class VideoController implements VideoControllerApiSpec{ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 작업 내용
✨ 참고 사항
⏰ 현재 버그
✏ Git Close