Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix os-release flavor #457

Closed
wants to merge 2 commits into from
Closed

Conversation

mauromorales
Copy link
Member

When calling the target from the kairos repo, we forgot to pass the flavor and the default value is opensuse-leap that is why this one showed up

Fixes kairos-io/kairos#1622

@mauromorales mauromorales requested a review from a team July 20, 2023 13:11
@mauromorales mauromorales self-assigned this Jul 20, 2023
@mauromorales mauromorales force-pushed the 1622-wrong-os-release-flavor branch from f1f651c to 9bc11fb Compare July 20, 2023 13:25
Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>
@mauromorales mauromorales force-pushed the 1622-wrong-os-release-flavor branch from b282405 to 0a52531 Compare July 20, 2023 13:31
Copy link
Member

@Itxaka Itxaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again? Isnt this the third time this happens?

Maybe there is something wrong with our process is this fails this much.

@mauromorales
Copy link
Member Author

good question, maybe first it was on kairos and now on provider, but I agree we need to make it more reliable

@simonfr
Copy link
Contributor

simonfr commented Jul 21, 2023

Hello,
duplicate of #451

@Itxaka Itxaka closed this Jul 21, 2023
@mauromorales mauromorales deleted the 1622-wrong-os-release-flavor branch July 24, 2023 07:28
@jimmykarily
Copy link
Contributor

Maybe it won't happen that much after this: kairos-io/kairos#1609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🐛 Wrong flavor argument on some (most?) os-release
4 participants