Fix flavor is not the core one for the provider images #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonfr
force-pushed
the
patch-kairos-flavor-for-provider
branch
2 times, most recently
from
d5c15b5 to
2b06088
Compare
|
ARM with buildx check KO seems to not be related to this MR. See for example, previous commit : https://github.com/kairos-io/provider-kairos/actions/runs/5573877300 Maybe the reason is : earthly/earthly#2957 |
Closed
Signed-off-by: Simon <[email protected]>
simonfr
force-pushed
the
patch-kairos-flavor-for-provider
branch
from
2b06088 to
983fa8d
Compare
|
No need to wait for CI, thanks @simonfr for the patch! |
|
Thank you @Itxaka. When do you plan to release the next version ? |
umm, not sure, we could do a minor bump of the provider-kairos only to bundle this fix.. |
How about today? :P https://github.com/kairos-io/provider-kairos/releases/tag/v2.3.1 |
|
Fixes kairos-io/kairos#1622 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass flavor to
OSRELEASEto not use default one defined at https://github.com/kairos-io/kairos/blob/master/Earthfile#L4.Issue : kairos-io/kairos#1607