Attach signer information to tx(s) endpoints #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to join from transactions to their signers
emmanueldenloye
suggested changes
Jul 14, 2023
| @@ -0,0 +1,2 @@ | |||
| ALTER TABLE signers DROP CONSTRAINT signers_pkey; | |||
There was a problem hiding this comment.
We should also change the primary key in haskell-src/lib/ChainwebDb/Types/Signer.hs
There was a problem hiding this comment.
Funny enough, the Haskell code already looks like it's declaring the first column of the primary key to be requestkey:
Seems like beam is being very haphazard here.
This was referenced Jul 21, 2023
enobayram
added a commit
to kadena-io/chainweb-api
that referenced
this pull request
Aug 1, 2023
This PR adds the signers list to the `TxDetail` type in order to support kadena-io/chainweb-data#152 which is a requirement for adding the signers information to the `txdetail` view of the block explorer. * Add Signers list to TxDetail * Add signatures to TxDetail
enobayram
added a commit
that referenced
this pull request
Aug 1, 2023
This PR is an amendment to #152, where we omitted the `sigs` field by oversight. * Add sigs field to tx detail responses * Bump CWA pin after merging API changes
enobayram
added a commit
to kadena-io/block-explorer
that referenced
this pull request
Aug 1, 2023
This PR adds the "Signers" and "Signatures" fields to the `txdetail` view. These new fields display the new `TxDetails` fields of the `chainweb-data` API added by kadena-io/chainweb-data#152 and kadena-io/chainweb-data#153. We used to have this information in the block transactions view before we redesigned that view to be a table of brief information about each transaction, each row linking to the corresponding `txdetail` page, losing the Signers and Signatures information in the process. This PR recovers these fields for the `block-explorer`. * Add Signers and Signatures fields to txdetail view * Remove Account and Scheme fields if they're empty * Rename Account field to Address * Separate the args of sig capabilities * Let txDetailPage accept a NonEmpty list * Rename txDetails * Add separators to signatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
_txDetail_signers :: [Signer]field to theTxDetailserved by theGET /txs/txandGET /txs/txsendpoints.Additionally:
ToSchematypes for the OAS3 spec.signerstable so that the primary key index supports efficient signer lookups.