-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Signers and Signatures fields to txdetail view #79
Conversation
Here are some example transactions with non-trivial "Signer" and "Signers" fields: I've hidden these screenshots because they got obsoleted by later commitshttp://localhost:8000/mainnet/txdetail/0CLa3cnmJlH0jPspdK1q8EDTKo-qMhRzmBUim5SiwD0 http://localhost:8000/mainnet/txdetail/-JZxl2e-EkY87WqYSZ07r9cRkQ4It1LQGV2Mgv52cMM http://localhost:8000/mainnet/txdetail/Gwgfnn5hbaJgzi15k1up3iwNroqF7s3HfvzdkQqTbSw |
The same screenshots after the latest commits (renaming Account -> Address and removing Address, Scheme if they're empty: I've hidden these screenshots because they got obsoleted by later commitshttp://localhost:8000/mainnet/txdetail/0CLa3cnmJlH0jPspdK1q8EDTKo-qMhRzmBUim5SiwD0 http://localhost:8000/mainnet/txdetail/Gwgfnn5hbaJgzi15k1up3iwNroqF7s3HfvzdkQqTbSw http://localhost:8000/mainnet/txdetail/-JZxl2e-EkY87WqYSZ07r9cRkQ4It1LQGV2Mgv52cMM |
The same screenshots after applying @emmanueldenloye's suggestion of separating SigCap arguments (also extended to the signatures list) http://localhost:8000/mainnet/txdetail/0CLa3cnmJlH0jPspdK1q8EDTKo-qMhRzmBUim5SiwD0 http://localhost:8000/mainnet/txdetail/Gwgfnn5hbaJgzi15k1up3iwNroqF7s3HfvzdkQqTbSw http://localhost:8000/mainnet/txdetail/-JZxl2e-EkY87WqYSZ07r9cRkQ4It1LQGV2Mgv52cMM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds the "Signers" and "Signatures" fields to the
txdetail
view. These new fields display the newTxDetails
fields of thechainweb-data
API added by kadena-io/chainweb-data#152 and kadena-io/chainweb-data#153.We used to have this information in the block transactions view before we redesigned that view to be a table of brief information about each transaction, each row linking to the corresponding
txdetail
page, losing the Signers and Signatures information in the process. This PR recovers these fields for theblock-explorer
.