Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Signers and Signatures fields to txdetail view #79

Merged
merged 7 commits into from
Aug 1, 2023

Conversation

enobayram
Copy link
Contributor

This PR adds the "Signers" and "Signatures" fields to the txdetail view. These new fields display the new TxDetails fields of the chainweb-data API added by kadena-io/chainweb-data#152 and kadena-io/chainweb-data#153.

We used to have this information in the block transactions view before we redesigned that view to be a table of brief information about each transaction, each row linking to the corresponding txdetail page, losing the Signers and Signatures information in the process. This PR recovers these fields for the block-explorer.

@enobayram enobayram self-assigned this Jul 21, 2023
@enobayram
Copy link
Contributor Author

enobayram commented Jul 21, 2023

Here are some example transactions with non-trivial "Signer" and "Signers" fields:

I've hidden these screenshots because they got obsoleted by later commits

http://localhost:8000/mainnet/txdetail/0CLa3cnmJlH0jPspdK1q8EDTKo-qMhRzmBUim5SiwD0

image


http://localhost:8000/mainnet/txdetail/-JZxl2e-EkY87WqYSZ07r9cRkQ4It1LQGV2Mgv52cMM

image


http://localhost:8000/mainnet/txdetail/Gwgfnn5hbaJgzi15k1up3iwNroqF7s3HfvzdkQqTbSw

image

@enobayram
Copy link
Contributor Author

enobayram commented Jul 21, 2023

The same screenshots after the latest commits (renaming Account -> Address and removing Address, Scheme if they're empty:

I've hidden these screenshots because they got obsoleted by later commits

http://localhost:8000/mainnet/txdetail/0CLa3cnmJlH0jPspdK1q8EDTKo-qMhRzmBUim5SiwD0

image


http://localhost:8000/mainnet/txdetail/Gwgfnn5hbaJgzi15k1up3iwNroqF7s3HfvzdkQqTbSw

image


http://localhost:8000/mainnet/txdetail/-JZxl2e-EkY87WqYSZ07r9cRkQ4It1LQGV2Mgv52cMM

image

frontend/src/Frontend/Page/TxDetail.hs Outdated Show resolved Hide resolved
frontend/src/Frontend/Page/TxDetail.hs Outdated Show resolved Hide resolved
frontend/src/Frontend/Page/TxDetail.hs Show resolved Hide resolved
@enobayram
Copy link
Contributor Author

Copy link
Contributor

@emmanueldenloye emmanueldenloye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants