Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespace removal #413

Merged
merged 5 commits into from
Feb 16, 2022

Conversation

Miles-Garnsey
Copy link
Member

What this PR does:

When I merged #387 it looked like all tests were passing but the multi-cluster tests just hadn't run. They all fail!

This is because the data plane kustomizations were wrong - they applied the same deletion patch that was already applied in the control-plane kustomizations from which data-plane is derived. Because the namespace is already deleted, this causes an error in kustomize build.

Which issue(s) this PR fixes:

Haven't raised one, this is a hotfix.

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@Miles-Garnsey Miles-Garnsey requested a review from a team as a code owner February 16, 2022 00:02
…is derived from `control-plane` kustomizations which already apply it.
@Miles-Garnsey
Copy link
Member Author

Miles-Garnsey commented Feb 16, 2022

I think this is good to merge despite some test failures:

  • ClusterScoped/MultiDcMultiCluster - has been failing consistently for some time.
  • CreateSingleDatacenterCluster - failed due toINSTALLATION FAILED: Service "traefik" is invalid: spec.ports[3].nodePort: Invalid value: 30080: provided port is already allocated This is likely something to do with a previous test not cleaning up after itself properly.
  • CreateSingleReaper this fails due to Reaper not being cleaned up properly. It was failing as of commit 595c2c3bca6660c708f72f1b940c686b9ec76e03 which was prior to my merge that broke the multi-cluster e2e tests this morning.
  • StopAndRestartDc consistently fails in most PRs at the moment.

@Miles-Garnsey Miles-Garnsey merged commit 7a316f0 into k8ssandra:main Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants